Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed legacy code from HotChocolate.Language #7193

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Jun 26, 2024

Summary of the changes (Less than 80 chars)

  • Removed legacy code from HotChocolate.Language.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 80.76923% with 20 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@99c61fe). Learn more about missing BASE report.

Files Patch % Lines
.../CodeGeneration/Analyzers/EnumTypeUsageAnalyzer.cs 77.27% 10 Missing ⚠️
...ypes/Utilities/ObjectValueToDictionaryConverter.cs 86.95% 6 Missing ⚠️
...neration/Analyzers/InputObjectTypeUsageAnalyzer.cs 71.42% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7193   +/-   ##
=======================================
  Coverage        ?   72.29%           
=======================================
  Files           ?     2619           
  Lines           ?   131485           
  Branches        ?        0           
=======================================
  Hits            ?    95055           
  Misses          ?    36430           
  Partials        ?        0           
Flag Coverage Δ
unittests 72.29% <80.76%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 911884f into main Jun 27, 2024
5 checks passed
@michaelstaib michaelstaib deleted the gai/remove-language-legacy branch June 27, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants