Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell-check code #7139

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Spell-check code #7139

merged 2 commits into from
Jun 3, 2024

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Jun 2, 2024

Summary of the changes (Less than 80 chars)

  • Corrected spelling errors in the src directory (excl. /test/).

ℹ️ These files are not yet checked in CI.

⚠️ Potentially-breaking changes to public API:

- .AddFiltering(compatabilityMode: true)
+ .AddFiltering(compatibilityMode: true)
- EnrichFromatHttpResponse
+ EnrichFormatHttpResponse

Copy link

codecov bot commented Jun 2, 2024

Codecov Report

Attention: Patch coverage is 75.41528% with 74 lines in your changes are missing coverage. Please review.

Project coverage is 72.55%. Comparing base (e0152e8) to head (8069763).
Report is 2 commits behind head on main.

Current head 8069763 differs from pull request most recent head e51d344

Please upload reports for the commit e51d344 to get more accurate results.

Files Patch % Lines
...ion.CSharp/Generators/OperationServiceGenerator.cs 44.44% 10 Missing ⚠️
....CSharp/Generators/InputValueFormatterGenerator.cs 0.00% 9 Missing ⚠️
...hemaRequestExecutorBuilderExtensions.Convention.cs 0.00% 6 Missing ⚠️
.../Core/src/Types/Types/Extensions/TypeExtensions.cs 33.33% 6 Missing ⚠️
...src/CodeGeneration.CSharp/Builders/ArrayBuilder.cs 0.00% 5 Missing ⚠️
...ore/src/Types/Properties/TypeResources.Designer.cs 33.33% 4 Missing ⚠️
....CSharp/Generators/DependencyInjectionGenerator.cs 50.00% 4 Missing ⚠️
...ors/JsonResultBuilderGenerator_EntityOrDataType.cs 0.00% 4 Missing ⚠️
...ion/Properties/CodeGenerationResources.Designer.cs 0.00% 4 Missing ⚠️
.../Extensions/SchemaBuilderExtensions.Conventions.cs 50.00% 3 Missing ⚠️
... and 14 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7139      +/-   ##
==========================================
- Coverage   78.36%   72.55%   -5.82%     
==========================================
  Files        2622     2639      +17     
  Lines      131762   132325     +563     
==========================================
- Hits       103259    96008    -7251     
- Misses      28503    36317    +7814     
Flag Coverage Δ
unittests 72.55% <75.41%> (-5.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 2, 2024

Qodana for .NET

5 new problems were found

Inspection name Severity Problems
Redundant using directive 🔶 Warning 2
Namespace does not correspond to file location 🔶 Warning 1
Type member is never used (private accessibility) 🔶 Warning 1
Method return value is never used (private accessibility) 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@michaelstaib michaelstaib merged commit a730ab0 into main Jun 3, 2024
9 checks passed
@michaelstaib michaelstaib deleted the gai/code-spell-check branch June 3, 2024 07:09
@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants