Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds resolver compiler source generator. #7137

Merged
merged 8 commits into from
Jun 4, 2024

Conversation

michaelstaib
Copy link
Member

No description provided.

Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 36.46409% with 115 lines in your changes missing coverage. Please review.

Project coverage is 72.45%. Comparing base (a730ab0) to head (802e48e).
Report is 1 commits behind head on main.

Current head 802e48e differs from pull request most recent head 9ea267c

Please upload reports for the commit 9ea267c to get more accurate results.

Files Patch % Lines
.../src/Types/Extensions/ResolverContextExtensions.cs 0.00% 39 Missing ⚠️
...ns/Parameters/ServiceParameterExpressionBuilder.cs 0.00% 13 Missing ⚠️
...rameters/EventMessageParameterExpressionBuilder.cs 0.00% 6 Missing ⚠️
...Parameters/IsSelectedParameterExpressionBuilder.cs 0.00% 4 Missing ⚠️
...s/Parameters/ArgumentParameterExpressionBuilder.cs 0.00% 3 Missing ⚠️
...eters/ClaimsPrincipalParameterExpressionBuilder.cs 0.00% 3 Missing ⚠️
...s/Parameters/DocumentParameterExpressionBuilder.cs 0.00% 3 Missing ⚠️
...ions/Parameters/FieldParameterExpressionBuilder.cs 0.00% 3 Missing ⚠️
...arameters/FieldSyntaxParameterExpressionBuilder.cs 0.00% 3 Missing ⚠️
...arameters/GlobalStateParameterExpressionBuilder.cs 0.00% 3 Missing ⚠️
... and 14 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7137      +/-   ##
==========================================
- Coverage   75.01%   72.45%   -2.57%     
==========================================
  Files        2622     2641      +19     
  Lines      131763   132503     +740     
==========================================
- Hits        98845    96001    -2844     
- Misses      32918    36502    +3584     
Flag Coverage Δ
unittests 72.45% <36.46%> (-2.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 31, 2024

Qodana for .NET

37 new problems were found

Inspection name Severity Problems
Unused local variable 🔴 Failure 4
Field is never used 🔴 Failure 3
Non-accessed field 🔴 Failure 2
Unused parameter (private accessibility) 🔶 Warning 16
Type member is never used (private accessibility) 🔶 Warning 5
Namespace does not correspond to file location 🔶 Warning 4
Unused type parameter 🔶 Warning 2
Type is never used (private accessibility) 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@michaelstaib michaelstaib merged commit 983faa0 into main Jun 4, 2024
3 of 4 checks passed
@michaelstaib michaelstaib deleted the mst/resolver-compiler-sourcegen branch June 4, 2024 16:57
=> parameter.Type.ToDisplayString() == WellKnownTypes.DocumentNode;

public static bool IsEventMessage(this IParameterSymbol parameter)
=> parameter.Type.ToDisplayString() == WellKnownAttributes.EnumTypeAttribute;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a typo?

Suggested change
=> parameter.Type.ToDisplayString() == WellKnownAttributes.EnumTypeAttribute;
=> parameter.Type.ToDisplayString() == WellKnownAttributes.EventMessageAttribute;

@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants