Do not emit "query": "" for Strawberry Shake persisted queries
#7062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
tobias-tengler
changed the title
"query": "" for Strawberry Shake persisted queries
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7062 +/- ##
==========================================
- Coverage 72.11% 71.87% -0.24%
==========================================
Files 2621 2607 -14
Lines 130776 130140 -636
==========================================
- Hits 94309 93543 -766
- Misses 36467 36597 +130
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When activating persisted queries with Strawberry Shake, it currently produces the following POST body:
{ "id":"692cb0da9a40c00ced7bba7463391db7", "query":"", "operationName":"BlogPagesById", "variables": { /* Omitted */ } }The
"query": ""part is problematic, since a Hot Chocolate server with theUseOnlyPersistedQueriesAllowedmiddleware will now reject the request.I fixed this by setting the query on
OperationRequestexplicitly tonull, so it will be correctly omitted when building the JSON payload.I also removed the unreferenced and unsupported
RequestStrategy.AutomaticPersistedQueryto avoid confusion.