Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CacheControlScope.Public per default #7058

Merged
merged 10 commits into from
Apr 22, 2024
Merged

Conversation

tobias-tengler
Copy link
Collaborator

Fixes #7055

@tobias-tengler tobias-tengler changed the title Fix cachecontrol scope Use CacheControlScope.Public per default Apr 13, 2024
Copy link

github-actions bot commented Apr 13, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@tobias-tengler tobias-tengler marked this pull request as ready for review April 13, 2024 21:17
@tobias-tengler tobias-tengler marked this pull request as draft April 13, 2024 21:21
@kiangkuang
Copy link
Contributor

Would it be more appropriate to allow the default scope be customizable similar to DefaultMaxAge, or should that be deferred to a future enhancement?

@tobias-tengler
Copy link
Collaborator Author

Yes, this can also be done, but it wouldn't address the underlying issue. I'm going to add it later.

@tobias-tengler tobias-tengler marked this pull request as ready for review April 14, 2024 20:23
@tobias-tengler tobias-tengler added the 👓 ready-for-review The PR is ready for review. label Apr 14, 2024
Copy link

github-actions bot commented Apr 14, 2024

Qodana for .NET

1 new problem were found

Inspection name Severity Problems
Redundant 'object.ToString()' call 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 72.08%. Comparing base (723733e) to head (d0c9fb1).
Report is 3 commits behind head on main.

❗ Current head d0c9fb1 differs from pull request most recent head 9d576ad. Consider uploading reports for the commit 9d576ad to get more accurate results

Files Patch % Lines
...olate/Caching/src/Caching/CacheControlAttribute.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7058      +/-   ##
==========================================
- Coverage   77.27%   72.08%   -5.20%     
==========================================
  Files        2632     2621      -11     
  Lines      131349   130776     -573     
==========================================
- Hits       101505    94265    -7240     
- Misses      29844    36511    +6667     
Flag Coverage Δ
unittests 72.08% <90.00%> (-5.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 2bab78e into main Apr 22, 2024
47 checks passed
@michaelstaib michaelstaib deleted the fix-cachecontrol-scope branch April 22, 2024 08:32
@PascalSenn PascalSenn mentioned this pull request May 22, 2024
@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HotChocolate.Caching with queries using DefaultMaxAge will be scoped to private
3 participants