Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fusion diagnostic events #7027

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Add Fusion diagnostic events #7027

merged 3 commits into from
Mar 29, 2024

Conversation

tobias-tengler
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Mar 28, 2024

Qodana for .NET

18 new problems were found

Inspection name Severity Problems
Redundant nullable warning suppression expression 🔶 Warning 14
Method return value is never used (private accessibility) 🔶 Warning 3
Unused type parameter 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@tobias-tengler tobias-tengler marked this pull request as ready for review March 28, 2024 12:52
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 45.71429% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 70.07%. Comparing base (7c6dc9a) to head (7788332).
Report is 2 commits behind head on main.

Files Patch % Lines
...njection/FusionRequestExecutorBuilderExtensions.cs 7.69% 12 Missing ⚠️
...Execution/Pipeline/OperationExecutionMiddleware.cs 72.72% 3 Missing ⚠️
...olate/Fusion/src/Core/Execution/Nodes/QueryPlan.cs 0.00% 2 Missing ⚠️
...ocolate/Fusion/src/Core/Execution/Nodes/Resolve.cs 0.00% 1 Missing ⚠️
...sion/src/Core/Execution/Nodes/ResolveByKeyBatch.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7027      +/-   ##
==========================================
- Coverage   72.80%   70.07%   -2.74%     
==========================================
  Files        2585     2571      -14     
  Lines      129491   128855     -636     
==========================================
- Hits        94282    90300    -3982     
- Misses      35209    38555    +3346     
Flag Coverage Δ
unittests 70.07% <45.71%> (-2.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit b033ea5 into main Mar 29, 2024
96 of 101 checks passed
@michaelstaib michaelstaib deleted the fusion-diagnostic-events branch March 29, 2024 07:19
@PascalSenn PascalSenn mentioned this pull request May 22, 2024
@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants