Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new node id serializer. #7026

Merged
merged 16 commits into from
Apr 4, 2024
Merged

Added new node id serializer. #7026

merged 16 commits into from
Apr 4, 2024

Conversation

michaelstaib
Copy link
Member

No description provided.

Copy link

github-actions bot commented Mar 28, 2024

Qodana for .NET

24 new problems were found

Inspection name Severity Problems
Namespace does not correspond to file location 🔶 Warning 14
Redundant using directive 🔶 Warning 5
Non-accessed positional property (private accessibility) 🔶 Warning 3
Redundant nullable warning suppression expression 🔶 Warning 1
Unused nullable directive 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 69.76744% with 65 lines in your changes are missing coverage. Please review.

Project coverage is 72.67%. Comparing base (8fbfa99) to head (23c2c3b).

Files Patch % Lines
...n/RequestExecutorBuilderExtensions.IdSerializer.cs 0.00% 35 Missing ⚠️
...c/Execution/Processing/MiddlewareContext.Global.cs 38.88% 11 Missing ⚠️
...c/Types/Types/Relay/GlobalIdInputValueFormatter.cs 72.22% 5 Missing ⚠️
...Filters/Types/FilterGlobalIdInputValueFormatter.cs 44.44% 5 Missing ⚠️
...ypes/Types/Relay/Extensions/RelayIdFieldHelpers.cs 75.00% 4 Missing ⚠️
...goDb/src/Data/Extensions/BsonDocumentExtensions.cs 0.00% 4 Missing ⚠️
...late/Core/src/Execution/RequestExecutorResolver.cs 97.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7026      +/-   ##
==========================================
- Coverage   72.69%   72.67%   -0.03%     
==========================================
  Files        2590     2590              
  Lines      129200   129200              
==========================================
- Hits        93922    93890      -32     
- Misses      35278    35310      +32     
Flag Coverage Δ
unittests 72.67% <69.76%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit df07a91 into main Apr 4, 2024
95 of 101 checks passed
@michaelstaib michaelstaib deleted the mst/nodeid-serializer branch April 4, 2024 13:00
@PascalSenn PascalSenn mentioned this pull request May 22, 2024
@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant