-
-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore when required variable was already added to selection #6995
ignore when required variable was already added to selection #6995
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6995 +/- ##
==========================================
- Coverage 74.42% 72.44% -1.98%
==========================================
Files 2608 2625 +17
Lines 131126 131689 +563
==========================================
- Hits 97584 95407 -2177
- Misses 33542 36282 +2740
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for creating this PR ... I will soon have a look. |
df90e5e
to
5b3b860
Compare
I will get this one in next week .... we have one massive PR that we need to merge first. |
Added new test where the User from Accounts can have a ProductConfiguration and ProductBookmark
matched by the username field instead of id. The bug fix is to ignore if a required variable was already added.
Closes #6993 (in this specific format)