Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore when required variable was already added to selection #6995

Merged

Conversation

rowe-stamy
Copy link
Contributor

Added new test where the User from Accounts can have a ProductConfiguration and ProductBookmark
matched by the username field instead of id. The bug fix is to ignore if a required variable was already added.
Closes #6993 (in this specific format)

@CLAassistant
Copy link

CLAassistant commented Mar 19, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.44%. Comparing base (a869df6) to head (b7252aa).

Current head b7252aa differs from pull request most recent head 2b9debe

Please upload reports for the commit 2b9debe to get more accurate results.

Files Patch % Lines
...ing/Pipeline/FieldRequirementsPlannerMiddleware.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6995      +/-   ##
==========================================
- Coverage   74.42%   72.44%   -1.98%     
==========================================
  Files        2608     2625      +17     
  Lines      131126   131689     +563     
==========================================
- Hits        97584    95407    -2177     
- Misses      33542    36282    +2740     
Flag Coverage Δ
unittests 72.44% <0.00%> (-1.98%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib
Copy link
Member

Thanks for creating this PR ... I will soon have a look.

@rowe-stamy rowe-stamy force-pushed the rwe/bugfix-fusion-required-variable branch from df90e5e to 5b3b860 Compare April 29, 2024 06:27
@michaelstaib
Copy link
Member

I will get this one in next week .... we have one massive PR that we need to merge first.

@michaelstaib michaelstaib merged commit 7d21ada into ChilliCream:main May 28, 2024
5 of 6 checks passed
@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants