Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DataLoader Scoping Improvements #6943

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Conversation

michaelstaib
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 70.73171% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 73.10%. Comparing base (a4d7d5e) to head (acbd95f).
Report is 1 commits behind head on main.

❗ Current head acbd95f differs from pull request most recent head e98d89c. Consider uploading reports for the commit e98d89c to get more accurate results

Files Patch % Lines
...hing/Extensions/ObjectFieldDataLoaderExtensions.cs 0.00% 11 Missing ⚠️
...colate/Core/src/Fetching/DefaultDataLoaderScope.cs 78.78% 7 Missing ⚠️
...colate/Core/src/Fetching/DataLoaderRegistration.cs 66.66% 2 Missing ⚠️
...Core/src/Fetching/DefaultDataLoaderScopeFactory.cs 77.77% 2 Missing ⚠️
...ion/RequestExecutorBuilderExtensions.DataLoader.cs 0.00% 1 Missing ⚠️
.../src/Fetching/Attributes/UseDataLoaderAttribute.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6943      +/-   ##
==========================================
+ Coverage   73.00%   73.10%   +0.09%     
==========================================
  Files        2584     2599      +15     
  Lines      128606   129428     +822     
==========================================
+ Hits        93893    94614     +721     
- Misses      34713    34814     +101     
Flag Coverage Δ
unittests 73.10% <70.73%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 26, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@michaelstaib michaelstaib merged commit 854d763 into main Feb 29, 2024
11 of 14 checks passed
@michaelstaib michaelstaib deleted the mst/dataloader-batching branch February 29, 2024 20:48
@PascalSenn PascalSenn mentioned this pull request May 22, 2024
@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant