Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include path for Fusion subgraph errors #6916

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

tobias-tengler
Copy link
Collaborator

@tobias-tengler tobias-tengler commented Feb 18, 2024

Fixes #6917

@tobias-tengler
Copy link
Collaborator Author

tobias-tengler commented Feb 18, 2024

@michaelstaib I'd like some feedback on how I should best approach fixing this. I was thinking of including the errors returned from a subgraph on the ExecutionState. In the compose queryplan node I'd then check if there is an error associated with what I'm composing into the final result. I checked and I should have everything available to use the PathHelper.CreatePathFromContext to create a path that corresponds to the final result.
Do you already see a reason why that wouldn't work or why it's conceptually wrong? I'm still in the process of exploring how Fusion actually works...

Copy link

github-actions bot commented Feb 18, 2024

Qodana for .NET

9 new problems were found

Inspection name Severity Problems
Redundant nullable warning suppression expression 🔶 Warning 9

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@michaelstaib michaelstaib changed the title [WIP] Include path for Fusion subgraph errors Include path for Fusion subgraph errors Mar 4, 2024
@michaelstaib michaelstaib marked this pull request as ready for review March 4, 2024 16:48
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 88.57143% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 70.14%. Comparing base (ed0449f) to head (2387595).

Files Patch % Lines
...ocolate/Fusion/src/Core/Execution/ExecutorUtils.cs 66.66% 2 Missing ⚠️
...sion/src/Core/Execution/Nodes/ResolveByKeyBatch.cs 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6916      +/-   ##
==========================================
- Coverage   72.80%   70.14%   -2.66%     
==========================================
  Files        2590     2590              
  Lines      129386   129386              
==========================================
- Hits        94194    90759    -3435     
- Misses      35192    38627    +3435     
Flag Coverage Δ
unittests 70.14% <88.57%> (-2.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 9479306 into main Mar 4, 2024
96 of 100 checks passed
@michaelstaib michaelstaib deleted the tte/fusion-subgraph-errors branch March 4, 2024 18:35
@PascalSenn PascalSenn mentioned this pull request May 22, 2024
@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fusion exposes subgraph errors without path
2 participants