Return proper exit codes from Fusion CLI #6911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6911 +/- ##
==========================================
+ Coverage 73.18% 73.19% +0.01%
==========================================
Files 2568 2568
Lines 127558 127558
==========================================
+ Hits 93355 93369 +14
+ Misses 34203 34189 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
michaelstaib
approved these changes
Feb 17, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently every command, even unsuccessful ones (like an unhandled exception), returns a 0 exit code.
An error during composition is therefore treated as success and won't fail CI, which just caused us some headaches... 😅
This PR returns the actual exit code as reported by the command handler or exception handler.