Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow root fields to be colocated. #6890

Merged
merged 5 commits into from
Feb 14, 2024
Merged

Allow root fields to be colocated. #6890

merged 5 commits into from
Feb 14, 2024

Conversation

michaelstaib
Copy link
Member

No description provided.

Copy link

github-actions bot commented Feb 13, 2024

Qodana for .NET

3 new problems were found

Inspection name Severity Problems
Private field can be converted into local variable 🔶 Warning 2
Redundant using directive 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8c26d3b) 73.16% compared to head (01e0659) 70.51%.
Report is 7 commits behind head on main.

❗ Current head 01e0659 differs from pull request most recent head f70f076. Consider uploading reports for the commit f70f076 to get more accurate results

Files Patch % Lines
...olate/Core/src/Abstractions/DataLoaderAttribute.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6890      +/-   ##
==========================================
- Coverage   73.16%   70.51%   -2.66%     
==========================================
  Files        2570     2568       -2     
  Lines      127876   127561     -315     
==========================================
- Hits        93561    89945    -3616     
- Misses      34315    37616    +3301     
Flag Coverage Δ
unittests 70.51% <0.00%> (-2.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib changed the title Source Generator Features Allow root fields to be colocated. Feb 14, 2024
@michaelstaib michaelstaib merged commit 8717279 into main Feb 14, 2024
6 checks passed
@michaelstaib michaelstaib deleted the mst/source-gen-impr branch February 14, 2024 05:33
@PascalSenn PascalSenn mentioned this pull request Feb 19, 2024
@PascalSenn PascalSenn mentioned this pull request May 22, 2024
@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant