Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use frozen dictionary in field cllection. #6889

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

michaelstaib
Copy link
Member

No description provided.

Copy link

github-actions bot commented Feb 13, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (9d44f09) 70.45% compared to head (74dc3c4) 70.46%.

Files Patch % Lines
...tChocolate/Core/src/Types/Schema.Initialization.cs 33.33% 2 Missing ⚠️
src/HotChocolate/Core/src/Types/SchemaTypes.cs 85.71% 1 Missing ⚠️
...tChocolate/Core/src/Types/Types/FieldCollection.cs 90.90% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6889   +/-   ##
=======================================
  Coverage   70.45%   70.46%           
=======================================
  Files        2570     2570           
  Lines      127710   127710           
=======================================
+ Hits        89974    89985   +11     
+ Misses      37736    37725   -11     
Flag Coverage Δ
unittests 70.46% <80.95%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit b343a2b into main Feb 13, 2024
99 of 100 checks passed
@michaelstaib michaelstaib deleted the mst/frozen-field-collection branch February 13, 2024 00:09
@PascalSenn PascalSenn mentioned this pull request Feb 19, 2024
@PascalSenn PascalSenn mentioned this pull request May 22, 2024
@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant