Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GreenDonut] Removed libraries available as part of framework from the reference list. #6879

Merged

Conversation

thompson-tomo
Copy link
Contributor

@thompson-tomo thompson-tomo commented Feb 9, 2024

Summary of the changes

  • Removed conditions for net standard 2.1 as not a TFM
  • Removed System.Threading.Tasks.Extensions & System.Diagnostics.DiagnosticSource from dependendencies when TFM is not net standard 2.0 due to being provided by Framework

Closes #6868

@CLAassistant
Copy link

CLAassistant commented Feb 9, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d9b3a66) 70.60% compared to head (ebaca1e) 70.58%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6879      +/-   ##
==========================================
- Coverage   70.60%   70.58%   -0.02%     
==========================================
  Files        2583     2583              
  Lines      128478   128478              
==========================================
- Hits        90707    90690      -17     
- Misses      37771    37788      +17     
Flag Coverage Δ
unittests 70.58% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib changed the title #6868 Removed libraries available as part of framework [GreenDonut] Removed libraries available as part of framework from the reference list. Feb 10, 2024
@michaelstaib michaelstaib merged commit 9062a25 into ChilliCream:main Feb 10, 2024
96 of 98 checks passed
@michaelstaib
Copy link
Member

Hey @thompson-tomo,

thanks for your work on this. Do you want to move on to Hot Chocolate and do the same there?

@thompson-tomo thompson-tomo deleted the chore/#6868-GreenDonutPackageClean branch February 10, 2024 22:12
@thompson-tomo
Copy link
Contributor Author

@michaelstaib Sure thing, can u re-open the existing issue or do you want me to create a new one or simply link to the closed one?

@michaelstaib
Copy link
Member

Hey @thompson-tomo,

as these are maintenance tasks a PR is enough.

@thompson-tomo
Copy link
Contributor Author

Pr all submitted for Hot Chocolate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependencies from Green Donut when provided by framework
3 participants