Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Typos in Strawberry Shake Network Documentation. #6685

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Fixed Typos in Strawberry Shake Network Documentation. #6685

merged 3 commits into from
Nov 9, 2023

Conversation

grounzero
Copy link
Contributor

Looking at the protocol table at the top of the page it appears the default has changed since v12 so this has been reflected in the description.

@github-actions github-actions bot added the 📚 documentation This issue is about working on our documentation. label Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (6965960) 78.98% compared to head (2f56c1e) 78.11%.
Report is 66 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6685      +/-   ##
==========================================
- Coverage   78.98%   78.11%   -0.88%     
==========================================
  Files        2903     2541     -362     
  Lines      139771   127086   -12685     
==========================================
- Hits       110397    99272   -11125     
+ Misses      29374    27814    -1560     
Flag Coverage Δ
unittests 78.11% <82.05%> (-0.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...e/src/CookieCrumble/Extensions/WriterExtensions.cs 100.00% <ø> (ø)
...CookieCrumble/src/CookieCrumble/TestEnvironment.cs 0.00% <ø> (ø)
...polloFederationRequestExecutorBuilderExtensions.cs 66.66% <100.00%> (ø)
...ensions/ApolloFederationSchemaBuilderExtensions.cs 86.66% <ø> (ø)
.../src/ApolloFederation/FederationTypeInterceptor.cs 100.00% <100.00%> (ø)
...ion/src/ApolloFederation/Helpers/ArgumentParser.cs 68.65% <100.00%> (+0.47%) ⬆️
...rc/AspNetCore.CommandLine/Command/ExportCommand.cs 100.00% <100.00%> (ø)
...tChocolateAspNetCoreServiceCollectionExtensions.cs 93.33% <ø> (+26.66%) ⬆️
...rc/AspNetCore/Extensions/HttpResponseExtensions.cs 26.31% <ø> (+4.57%) ⬆️
...pNetCore/src/AspNetCore/GraphQLRequestException.cs 25.00% <ø> (+5.00%) ⬆️
... and 13 more

... and 877 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib changed the title change default subscription protocol Fixed Typos in Strawberry Shake Network Documentation. Nov 9, 2023
@michaelstaib michaelstaib merged commit 793b9c2 into ChilliCream:main Nov 9, 2023
89 of 98 checks passed
@grounzero grounzero deleted the patch-1 branch November 9, 2023 19:53
@PascalSenn PascalSenn mentioned this pull request Feb 19, 2024
@PascalSenn PascalSenn mentioned this pull request May 22, 2024
@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation This issue is about working on our documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants