Allow postgres subscriptions to be configured in publish only mode

[williamdenton]

Allows postgres subscription transport to be used in processes that perform publish operations only
see #6511

Closes #6511

[CLAassistant]

All committers have signed the CLA.

[williamdenton]

maybe too DRY? not sure if its best to duplicate some of the code rather than reuse it the way i have here

[github-actions]

HotChocolate.Data.Spatial.Filters.QueryableFilterVisitorDistanceTests.Create_Distance_Expression [FAIL]
HotChocolate.Data.Spatial.Filters.QueryableFilterVisitorWithinTests.Create_Within_Query [FAIL]

[github-actions]

HotChocolate.Subscriptions.Postgres.AsyncTaskDispatcherTests.Dispatch_Should_InvokeHandler [FAIL]

[github-actions]

HotChocolate.Execution.Integration.StarWarsCodeFirst.StarWarsCodeFirstTests.Depth_Analysis_Overrides_Are_Not_Cached [FAIL]

[codecov]

Codecov Report

Patch coverage: 95.65% and project coverage change: +0.04% 🎉

Comparison is base (485a4a9) 78.98% compared to head (7ef297e) 79.03%.
Report is 5 commits behind head on main.

❗ Current head 7ef297e differs from pull request most recent head 886b44a. Consider uploading reports for the commit 886b44a to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6512      +/-   ##
==========================================
+ Coverage   78.98%   79.03%   +0.04%     
==========================================
  Files        2903     2917      +14     
  Lines      139764   140371     +607     
==========================================
+ Hits       110395   110943     +548     
- Misses      29369    29428      +59     

Flag	Coverage Δ
unittests	79.03% <95.65%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...on/CoreSubscriptionsServiceCollectionExtensions.cs	88.88% <92.30%> (ø)
...ostgres/PostgresSubscriptionTransportExtensions.cs	95.83% <100.00%> (ø)

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

HotChocolate.Execution.Integration.Spec.MutationTests.Ensure_Mutations_Are_Executed_Serially [FAIL]
HotChocolate.Execution.Batching.BatchQueryExecutorTests.ExecuteExportScalarList_ExplicitVariable [FAIL]

[github-actions]

HotChocolate.Subscriptions.Postgres.BackgroundTaskTests.RunContinuously_Should_WaitForASecond_When_HandlerThrowsException [FAIL]

[williamdenton]

I've just had another thought - the ITopicSender should participate in transactions (enlist) so the event is published when related data is committed to the database. Obviously the receiver needs to be independent of any transaction and pooling as it currently is

[PascalSenn]

This PR looks good. Thanks for the contribution!

(Just one minor formatting comment)

[github-actions]

HotChocolate.Data.Spatial.Filters.QueryableFilterVisitorIntersectsTests.Create_Intersects_Query [FAIL]

[github-actions]

HotChocolate.Subscriptions.Postgres.BackgroundTaskTests.RunContinuously_Should_WaitForASecond_When_HandlerThrowsException [FAIL]

[github-actions]

HotChocolate.Execution.Integration.Spec.MutationTests.Ensure_Mutations_Child_Fields_Are_Scoped_To_Its_Parent [FAIL]
HotChocolate.Execution.Integration.StarWarsCodeFirst.StarWarsCodeFirstTests.GraphQLOrgDirectiveSkipExample1WithPlainClrVarTypes [FAIL]
HotChocolate.Execution.Integration.DataLoader.DataLoaderTests.FetchSingleDataLoader [FAIL]

[PascalSenn]

I've just had another thought - the ITopicSender should participate in transactions (enlist) so the event is published when related data is committed to the database. Obviously the receiver needs to be independent of any transaction and pooling as it currently is

Yes i agree. this would solve a couple of issues. e.g:

• When you are in a transaction and you store an update and notify about the update, it's likely that the message is received on the consumer side before the data is actually updated in the database
• When your transaction fails, the notification still arrives.

There are a couple of issue on the implemntation side with this though:

• We currenlty batch the send notifications for higher throughput on inserts (it's like 10x more throughput)
• The ITopicEventSenver runs decoupled from the context of the request

I have talked with @michaelstaib about this before, but we only really cut the topics ones in a discussion. Maybe we can pick this up again. There are a few adjustments that we would have to make to make this work.

[github-actions]

HotChocolate.Data.Spatial.Filters.QueryableFilterVisitorIntersectsTests.Create_Intersects_Query [FAIL]
HotChocolate.Data.Spatial.Filters.QueryableFilterVisitorOverlapsTests.Create_Overlaps_Query [FAIL]

[williamdenton]

We discussed this internally too and it is tricky to reason about. Leaving it as is is simpler and we can easily work around it. Using a different backend like redis you would not get any guarantees on transaction related dispatch

[github-actions]

HotChocolate.Subscriptions.Postgres.BackgroundTaskTests.RunContinuously_Should_WaitForASecond_When_HandlerThrowsException [FAIL]

[github-actions]

HotChocolate.Execution.Integration.StarWarsCodeFirst.StarWarsCodeFirstTests.GraphQLOrgVariableWithDefaultValueExample [FAIL]
HotChocolate.Execution.Integration.DataLoader.DataLoaderTests.ClassDataLoader_Resolve_From_DependencyInjection [FAIL]

[github-actions]

HotChocolate.Data.Spatial.Filters.QueryableFilterVisitorDistanceTests.Create_Distance_Expression [FAIL]

[github-actions]

HotChocolate.Execution.Integration.DataLoader.DataLoaderTests.ClassDataLoader_Resolve_From_DependencyInjection [FAIL]

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[PascalSenn]

@williamdenton Thanks for the contribution!

[williamdenton]

I'm guessing this will be in 13.6 rather than 13.5.x?