Fix naming issues with generic types

[N-Olbert]

Summary of the changes (Less than 80 chars)

• Dynamically determine the index of the `-char
• Consider GraphQLNameAttribute for generic types

Closes #6392 and #6293

[CLAassistant]

All committers have signed the CLA.

[michaelstaib]

Thanks for contributing.

I have one issue with the PR. This should be named Bar. It is in any case a bad schema design to expose these generated names ... but this takes away the ability to fix the name. Further, it breaks behavior, effecting everyone who uses this behavior without a way out of this.

[GraphQLName("Bar")] // Note
    public class Foo<T>
    {
        public T Test { get; init; }
    }

I know that this can be many types .... But we cannot break behavior here.

[github-actions]

HotChocolate.Subscriptions.Postgres.BackgroundTaskTests.RunContinuously_Should_WaitForASecond_When_HandlerThrowsException [FAIL]

[github-actions]

HotChocolate.Execution.Integration.StarWarsCodeFirst.StarWarsCodeFirstTests.Depth_Analysis_Overrides_Are_Not_Cached [FAIL]

[codecov]

Codecov Report

Patch coverage: 86.36% and project coverage change: -0.03% ⚠️

Comparison is base (1e78ece) 78.99% compared to head (98dfd6b) 78.96%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6461      +/-   ##
==========================================
- Coverage   78.99%   78.96%   -0.03%     
==========================================
  Files        2911     2897      -14     
  Lines      139228   138627     -601     
==========================================
- Hits       109978   109464     -514     
+ Misses      29250    29163      -87     

Flag	Coverage Δ
unittests	78.96% <86.36%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...ate/Core/src/Abstractions/NameFormattingHelpers.cs	88.69% <86.36%> (ø)

... and 37 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[N-Olbert]

@michaelstaib We could introduce a property to configure this, how about (naming is for sure not the best)

[GraphQLName("Bar", IncludeTypeParameterNaming = true)]
public class Foo<T>
{
    public T Test { get; init; }
}

IncludeTypeParameterNaming = true becomes BarOfType
IncludeTypeParameterNaming = false (default) becomes Bar

[github-actions]

HotChocolate.Subscriptions.Postgres.BackgroundTaskTests.RunContinuously_Should_WaitForASecond_When_HandlerThrowsException [FAIL]

[github-actions]

HotChocolate.Execution.Integration.DataLoader.DataLoaderTests.ClassDataLoader_Resolve_From_DependencyInjection [FAIL]

[michaelstaib]

I sat down with @PascalSenn to discuss it a bit ... we can still pin the legacy behavior, which is important to get this into a dot release. I modified the test a bit to include this pinning behavior. We will merge it once the build is done.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[michaelstaib]

https://github.com/ChilliCream/graphql-platform/releases/tag/13.5.0-preview.22

[michaelstaib]

Thanks again for contributing!

[ZhelninMaksim]

Is there any way I can skip or override this behavior? In the last version, I defined the names for such types myself and would like to keep that behavior, is it possible?

[N-Olbert]

@ZhelninMaksim : You may overwrite the name using a custom attribute. This has precedence.

public sealed class CustomGenericTypeName : DescriptorAttribute
{
    public string Name {get; init;} = default!;

    protected override void TryConfigure(IDescriptorContext context, IDescriptor descriptor, ICustomAttributeProvider element)
    {
        if (descriptor is IObjectTypeDescriptor d)
        {
            d.Name(Name);
        }
    }
}