Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include net8.0 tools in StrawberryShake package #6395

Merged

Conversation

repne
Copy link
Contributor

@repne repne commented Jul 30, 2023

Adding StrawberryShake.Server to a dotnet 8 project will generate an error:

Could not execute because the specified command or file was not found.
  Possible reasons for this include:
    * You misspelled a built-in dotnet command.
    * You intended to execute a .NET program, but dotnet-/Users/antonio/.nuget/packages/strawberryshake.server/13.5.0-preview.7/build/../tools/net8/dotnet-graphql.dll does not exist.
    * You intended to run a global tool, but a dotnet-prefixed executable with this name could not be found on the PATH.

/Users/antonio/.nuget/packages/strawberryshake.server/13.5.0-preview.7/build/StrawberryShake.Server.targets(79,5): error MSB3073: The command "dotnet "/Users/antonio/.nuget/packages/strawberryshake.server/13.5.0-preview.7/build/../tools/net8/dotnet-graphql.dll" generate "/Users/antonio/Desktop/src/Demo" -o "/Users/antonio/Desktop/src/Demo/obj/Debug/net8.0/berry" -n Demo -a md5 -t" exited with code 1.

The tools directory does not have net8 subdirectory:

> ls /Users/antonio/.nuget/packages/strawberryshake.server/13.5.0-preview.7/tools
net6 net7

Tested on dotnet 8.0.100-preview.6.23330.14 with HC 13.4.0 and 13.5.0-preview.7

This PR adds the missing files to StrawberryShake package

@CLAassistant
Copy link

CLAassistant commented Jul 30, 2023

CLA assistant check
All committers have signed the CLA.

@repne repne marked this pull request as ready for review July 30, 2023 00:56
@michaelstaib michaelstaib merged commit 388f5c9 into ChilliCream:main Jul 30, 2023
2 checks passed
@michaelstaib
Copy link
Member

Thank you for contributing.

This was referenced Sep 10, 2023
renovate bot referenced this pull request in orso-co/Orso.Arpa.Api Sep 16, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [HotChocolate.Abstractions](https://chillicream.com/)
([source](https://togithub.com/ChilliCream/graphql-platform)) | nuget |
minor | `13.4.0` -> `13.5.1` |
| [HotChocolate.AspNetCore](https://chillicream.com/)
([source](https://togithub.com/ChilliCream/graphql-platform)) | nuget |
minor | `13.4.0` -> `13.5.1` |
| [HotChocolate.AspNetCore.Authorization](https://chillicream.com/)
([source](https://togithub.com/ChilliCream/graphql-platform)) | nuget |
minor | `13.4.0` -> `13.5.1` |
| [HotChocolate.Data](https://chillicream.com/)
([source](https://togithub.com/ChilliCream/graphql-platform)) | nuget |
minor | `13.4.0` -> `13.5.1` |
| [HotChocolate.Data.EntityFramework](https://chillicream.com/)
([source](https://togithub.com/ChilliCream/graphql-platform)) | nuget |
minor | `13.4.0` -> `13.5.1` |
| [HotChocolate.Types](https://chillicream.com/)
([source](https://togithub.com/ChilliCream/graphql-platform)) | nuget |
minor | `13.4.0` -> `13.5.1` |

---

### Release Notes

<details>
<summary>ChilliCream/graphql-platform
(HotChocolate.Abstractions)</summary>

###
[`v13.5.1`](https://togithub.com/ChilliCream/graphql-platform/releases/tag/13.5.1)

[Compare
Source](https://togithub.com/ChilliCream/graphql-platform/compare/13.5.0...13.5.1)

##### What's Changed

- StrawberryShake public access modifier must be default. by
[@&#8203;michaelstaib](https://togithub.com/michaelstaib) in
[https://github.com/ChilliCream/graphql-platform/pull/6472](https://togithub.com/ChilliCream/graphql-platform/pull/6472)

**Full Changelog**:
ChilliCream/graphql-platform@13.5.0...13.5.1

###
[`v13.5.0`](https://togithub.com/ChilliCream/graphql-platform/releases/tag/13.5.0)

[Compare
Source](https://togithub.com/ChilliCream/graphql-platform/compare/13.4.0...13.5.0)

#### What's Changed

- Added GraphQL Request Field Limit. by
[@&#8203;michaelstaib](https://togithub.com/michaelstaib) in
[https://github.com/ChilliCream/graphql-platform/pull/6381](https://togithub.com/ChilliCream/graphql-platform/pull/6381)
- Fixed Subscription Complete Issue for ValueType Message. by
[@&#8203;michaelstaib](https://togithub.com/michaelstaib) in
[https://github.com/ChilliCream/graphql-platform/pull/6383](https://togithub.com/ChilliCream/graphql-platform/pull/6383)
- Optimized the Type Module Source Generator by
[@&#8203;michaelstaib](https://togithub.com/michaelstaib) in
[https://github.com/ChilliCream/graphql-platform/pull/6388](https://togithub.com/ChilliCream/graphql-platform/pull/6388)
- Adds postgres transport for subscriptions by
[@&#8203;PascalSenn](https://togithub.com/PascalSenn) in
[https://github.com/ChilliCream/graphql-platform/pull/6387](https://togithub.com/ChilliCream/graphql-platform/pull/6387)
- Expose internals of Fusion to BCP services by
[@&#8203;PascalSenn](https://togithub.com/PascalSenn) in
[https://github.com/ChilliCream/graphql-platform/pull/6390](https://togithub.com/ChilliCream/graphql-platform/pull/6390)
- Include .NET 8.0 tools in StrawberryShake package by
[@&#8203;repne](https://togithub.com/repne) in
[https://github.com/ChilliCream/graphql-platform/pull/6395](https://togithub.com/ChilliCream/graphql-platform/pull/6395)
- Upgrade default BCP middleware version by
[@&#8203;PascalSenn](https://togithub.com/PascalSenn) in
[https://github.com/ChilliCream/graphql-platform/pull/6410](https://togithub.com/ChilliCream/graphql-platform/pull/6410)
- Scope the projection selection properly when using the mutation
conventions. by [@&#8203;hahn-kev](https://togithub.com/hahn-kev) in
[https://github.com/ChilliCream/graphql-platform/pull/6444](https://togithub.com/ChilliCream/graphql-platform/pull/6444)
- Reintroduce RequestContextAccessor by
[@&#8203;michaelstaib](https://togithub.com/michaelstaib) in
[https://github.com/ChilliCream/graphql-platform/pull/6454](https://togithub.com/ChilliCream/graphql-platform/pull/6454)
- Publicly expose ability to register an error type on a mutation field
by [@&#8203;benmccallum](https://togithub.com/benmccallum) in
[https://github.com/ChilliCream/graphql-platform/pull/6463](https://togithub.com/ChilliCream/graphql-platform/pull/6463)
- Removed Path Pooling by
[@&#8203;michaelstaib](https://togithub.com/michaelstaib) in
[https://github.com/ChilliCream/graphql-platform/pull/6394](https://togithub.com/ChilliCream/graphql-platform/pull/6394)
- Fixed naming issues with generic types by
[@&#8203;N-Olbert](https://togithub.com/N-Olbert) in
[https://github.com/ChilliCream/graphql-platform/pull/6461](https://togithub.com/ChilliCream/graphql-platform/pull/6461)
- Fixed Batch Pool for DataLoader was cleared to early. by
[@&#8203;michaelstaib](https://togithub.com/michaelstaib) in
[https://github.com/ChilliCream/graphql-platform/pull/6465](https://togithub.com/ChilliCream/graphql-platform/pull/6465)
- Added configurable access for generated Strawberry Shake clients
([#&#8203;6374](https://togithub.com/ChilliCream/graphql-platform/issues/6374))
by [@&#8203;nih0n](https://togithub.com/nih0n) in
[https://github.com/ChilliCream/graphql-platform/pull/6416](https://togithub.com/ChilliCream/graphql-platform/pull/6416)

**Full Changelog**:
ChilliCream/graphql-platform@13.4.0...13.5.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 10pm every weekday,every
weekend,before 5am every weekday" in timezone Europe/Berlin, Automerge -
At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/orso-co/Orso.Arpa.Api).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants