Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DotNetVersion parse order (#6180) #6190

Merged
merged 1 commit into from
May 23, 2023
Merged

Fix DotNetVersion parse order (#6180) #6190

merged 1 commit into from
May 23, 2023

Conversation

michaelmccord
Copy link
Contributor

The errors noted in #6180 are due to a race condition between the evaluation of the property and the execution of the dotnet --version command.

Closes #6180

@CLAassistant
Copy link

CLAassistant commented May 23, 2023

CLA assistant check
All committers have signed the CLA.

@michaelstaib
Copy link
Member

Thank you for your help!

@michaelstaib michaelstaib merged commit 3a7d457 into ChilliCream:main May 23, 2023
@michaelmccord
Copy link
Contributor Author

michaelmccord commented May 23, 2023

Thank you for your help!

@michaelstaib No problem. Can this get backed merged into the 13.1.x line?

@michaelstaib
Copy link
Member

Yes ... there is already a preview build... or there will be in 15 min

@michaelmccord
Copy link
Contributor Author

Yes ... there is already a preview build... or there will be in 15 min

Awesome. Thanks!

@huysentruitw
Copy link
Contributor

huysentruitw commented May 26, 2023

Is there a reason for not using $(TargetFrameworkVersion) instead of generating a DotNetVersion using the cli?

F.e:

    <PropertyGroup>
      <DotNetMajor Condition="$([MSBuild]::VersionGreaterThanOrEquals($(TargetFrameworkVersion), 6))">6</DotNetMajor>
      <DotNetMajor Condition="$([MSBuild]::VersionGreaterThanOrEquals($(TargetFrameworkVersion), 7))">7</DotNetMajor>
    </PropertyGroup>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StrawberryShake.Server.targets cannot evaluate ::VersionGreaterThanOrEquals(' ', 6)
4 participants