Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue JSON scalar crashes on JsonElement inputs #6023 #6029

Merged
merged 5 commits into from
Apr 12, 2023
Merged

Fix issue JSON scalar crashes on JsonElement inputs #6023 #6029

merged 5 commits into from
Apr 12, 2023

Conversation

onionhammer
Copy link
Contributor

@onionhammer onionhammer commented Apr 5, 2023 •
edited
Loading

Fix issue parsing JSON scalar inputs

  • Adds a 'bytes written' to call to GetSpan so that JsonElement.ParseValue only attempts to read the actual bytes written, rather than continuing to read the underlying buffer.
  • Added test case

Closes #6023

@CLAassistant
Copy link

CLAassistant commented Apr 5, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@michaelstaib
Copy link
Member

Why not just flush?

@michaelstaib michaelstaib added this to the HC-13.1.0 milestone Apr 6, 2023
@michaelstaib michaelstaib merged commit f49078e into ChilliCream:main Apr 12, 2023
@onionhammer onionhammer deleted the Fix-issue-parsing-JSON-inputs branch April 12, 2023 14:08
@PascalSenn PascalSenn mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib Awaiting requested review from michaelstaib

Assignees
No one assigned
Labels
🌶️ hot chocolate
Projects
None yet
Milestone
HC-13.1.0
Development

Successfully merging this pull request may close these issues.

JSON scalar crashes on JsonElement inputs
3 participants
@onionhammer @CLAassistant @michaelstaib