Fixed StrawberryShake result has empty Extensions Issue

[anton-gogolev]

This is my naïve attempt to fix #4956.

There are no meaningful tests for this fix; I hacked around existing one to get this thing to kinda-sorta work to fit my use-case. I'm all ears and open to suggestions as to how improve this PR.

[CLAassistant]

All committers have signed the CLA.

[michaelstaib]

Hey there,

thank you for contributing.

Can you add some integration tests so that we can see that this works?

[anton-gogolev]

@michaelstaib Not sure about integration tests, but I added a simple unit test that does some basic assertions.

From what I could understand, objects of Response class have very few properties ever initialized, so spinning up a full GraphQL server and then invoking it from an integration test sounds a bit excessive: we can just "pretend" that we've got a JSON document from "the network" and just "build" an OperationResult instance out of it.

Also, I've just empirically confirmed that the fix in fact works.

[anton-gogolev]

@michaelstaib What would be my (or some else's) next steps on this?

[nightroman]

@michaelstaib What else is needed? Can this fix make into 13.1? How can we help in addition to the @anton-gogolev fix and unit test? The extensions field is the part of GraphQL specs and Strawberry Shake not respecting it causes real pain...

[michaelstaib]

Yes

[michaelstaib]

We will add it to 13.1

[michaelstaib]

Should be merged after the weekend and available as preview

[nightroman]

@michaelstaib Thank you, it's a great news!!! @anton-gogolev many thanks for the fix!

[anton-gogolev]

@michaelstaib A friendly ping here. Is anything required here from me?

[nightroman]

@michaelstaib https://github.com/ChilliCream/graphql-platform/releases/tag/13.1.0-preview.5 is out with this fix promised to be included

Should be merged after the weekend and available as preview

It's all right if it is not forgotten as such and will get into 13.1. But we worry a little... and we do not have a chance to test a preview, who knows, the merge may bring surprises.

[nightroman]

@michaelstaib could you please merge this PR so that it is included in the preview and we can test? We promise to test and report whatever the outcome is. You should be interested in any outcome and our feedback, right?

[RobAltium]

@michaelstaib Sorry to nag ... can this be merged please? Who else can review? This is holding up @anton-gogolev and our Altium365 team...

[michaelstaib]

Its merged and will be in the next build.