Use structs with non-default constructors as input types w/o configuring #5844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for providing this fix. But it also needs a test in order to progress further. |
1 task
src/HotChocolate/Core/test/Types.Tests/Configuration/TypeDiscoveryTests.cs
Show resolved
Hide resolved
|
This PR was marked 13.0.5 but it's not in 13.0.5 😢 |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
martindisch
pushed a commit
to martindisch/graphql-platform
that referenced
this pull request
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product: HotChocolate
Currently structs with all writable properties and non-default constructors cannot be used as input types without explicit configuration (schema build fails with
No compatible constructor found for input type type 'T'). However structs always have an implicit default constructor, which is used byExpression.New(type).