Adds startsWith and nstartsWith to Elastic Search #5020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PascalSenn
reviewed
May 2, 2022
src/HotChocolate/ElasticSearch/test/Data.ElasticSearch.Tests/StringPrefixTests.cs
Outdated
Show resolved
Hide resolved
PascalSenn
requested changes
May 2, 2022
There was a problem hiding this comment.
@frzmohammadali Awesome work! This PR looks already really good :)
A few things i noticed:
- We have a pretty strict 100 characters line length. Can you break the queries when possible?
- Could it be that there are some query snapshots missing or is there something wrong with the test helper?
...cSearch.Tests/__snapshots__/StringPrefixTests.ElasticSearch_AndField_WithNegation_query.snap
Show resolved
Hide resolved
...ch/test/Data.ElasticSearch.Tests/__snapshots__/StringPrefixTests.ElasticSearch_AndField.snap
Show resolved
Hide resolved
...st/Data.ElasticSearch.Tests/__snapshots__/StringPrefixTests.ElasticSearch_MultipleField.snap
Show resolved
Hide resolved
...sticSearch.Tests/__snapshots__/StringPrefixTests.ElasticSearch_MultipleField_OneNegated.snap
Show resolved
Hide resolved
|
@PascalSenn Thanks a lot for your feedback. I'll take care of the points you mentioned and submit an update soon (this evening hopefully) :) |
PascalSenn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Two filter operation handlers has been added for string operations with ElasticSearch:
startsWithnstartsWithElastic search query to be used for these operations is the
PrefixQueryunder term-level type of queries.Tests are available in
StringPrefixTests.csfile.Feedbacks are more than welcome ;)