Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3678 support value type extended scalars in Strawberry Shake #4595

Merged

Conversation

retterbot
Copy link
Contributor

Add support for value type scalars

  • The current implementation of TypeInfos has a dictionary of type mappings, during the registration phase where scalar extensions are registered it creates new RuntimeTypeInfos but it does not register them. This means that when the schema file itself is processed the extended type information is lost and so all types are registered as non value types as this is the default.
  • To resolve this, during the registration phase, the created RuntimeTypeInfo is added to the dictionary.
  • The implementation isn't thread-safe I assume this is OK as the calling code runs on a single thread.

Closes #3678

@michaelstaib
Copy link
Member

@PascalSenn can you do the review? It should actually already be fixed now but the tests are still useful.

@PascalSenn
Copy link
Member

@brian-tygotech Thanks for the contribution ! Timing was a bit unfortunate as this was already resolved in another branch. But the tests are still super helpful!
LGTM

@PascalSenn PascalSenn added the 🎬 ready Ready to merge label Jan 6, 2022
@michaelstaib michaelstaib merged commit 2b39ed9 into ChilliCream:main Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StrawberryShake generated formatter is checking null for non-nullable type
3 participants