Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQLClientException: improve case of 1 error #4528

Merged
merged 2 commits into from
Dec 9, 2021
Merged

GraphQLClientException: improve case of 1 error #4528

merged 2 commits into from
Dec 9, 2021

Conversation

jorrit
Copy link
Contributor

@jorrit jorrit commented Dec 8, 2021 •
edited
Loading

StrawBerry Shake throws a GraphQLClientException with any number of errors when EnsureNoErrors() is called.

Even when there's just one error, the resulting message contains Multiple errors occured. This PR fixes that, and:

  1. Adds a special case for 0 errors, which I see is used by generated code
  2. Fixes the occured typo (although it also exists elsewhere and may need its own PR)
  3. Makes sure each error appears on its own line

@jorrit jorrit force-pushed the clientexceptionsingleerror branch from 418f313 to 8593829 Compare December 8, 2021 19:09
@jorrit jorrit force-pushed the clientexceptionsingleerror branch from 8593829 to 70bbd86 Compare December 8, 2021 19:13
@michaelstaib
Copy link
Member

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@michaelstaib michaelstaib merged commit 0a82323 into ChilliCream:main Dec 9, 2021
@michaelstaib
Copy link
Member

I have integrated this into 12.4 ... the other prs you have done will go in 12.5.

@renovate renovate bot mentioned this pull request Dec 14, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib michaelstaib approved these changes

Assignees
No one assigned
Labels
🌶️ strawberry shake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorrit @michaelstaib