Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing this to ModifyFunctionOptions. #4454

Merged
merged 5 commits into from
Nov 19, 2021
Merged

Added missing this to ModifyFunctionOptions. #4454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
42db803
Added missing to ModifyFunctionOptions
michaelstaib Nov 19, 2021
e991ed1
Public API
michaelstaib Nov 19, 2021
03e68dd
Marked API Shipped for 12.3.1
michaelstaib Nov 19, 2021
43c84ce
Fixed Public API
michaelstaib Nov 19, 2021
cd655e5
Fixed API
michaelstaib Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ocolate.AzureFunctions/Extensions/HotChocolateAzureFunctionServiceCollectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public static IRequestExecutorBuilder AddGraphQLFunction(
/// Returns <see cref="IRequestExecutorBuilder"/> so that configuration can be chained.
/// </returns>
public static IRequestExecutorBuilder ModifyFunctionOptions(
IRequestExecutorBuilder builder,
this IRequestExecutorBuilder builder,
Action<GraphQLServerOptions> configure)
{
if (builder is null)
Expand Down
2 changes: 1 addition & 1 deletion src/HotChocolate/AzureFunctions/src/HotChocolate.AzureFunctions/PublicAPI.Shipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ Microsoft.Azure.Functions.Extensions.DependencyInjection.HotChocolateFunctionsHo
Microsoft.Extensions.DependencyInjection.HotChocolateAzureFunctionServiceCollectionExtensions
static Microsoft.Azure.Functions.Extensions.DependencyInjection.HotChocolateFunctionsHostBuilderExtensions.AddGraphQLFunction(this Microsoft.Azure.Functions.Extensions.DependencyInjection.IFunctionsHostBuilder! builder, int maxAllowedRequestSize = 20000000, string! apiRoute = "/api/graphql") -> HotChocolate.Execution.Configuration.IRequestExecutorBuilder!
static Microsoft.Extensions.DependencyInjection.HotChocolateAzureFunctionServiceCollectionExtensions.AddGraphQLFunction(this Microsoft.Extensions.DependencyInjection.IServiceCollection! services, int maxAllowedRequestSize = 20000000, string! apiRoute = "/api/graphql") -> HotChocolate.Execution.Configuration.IRequestExecutorBuilder!
static Microsoft.Extensions.DependencyInjection.HotChocolateAzureFunctionServiceCollectionExtensions.ModifyFunctionOptions(HotChocolate.Execution.Configuration.IRequestExecutorBuilder! builder, System.Action<HotChocolate.AspNetCore.GraphQLServerOptions!>! configure) -> HotChocolate.Execution.Configuration.IRequestExecutorBuilder!
static Microsoft.Extensions.DependencyInjection.HotChocolateAzureFunctionServiceCollectionExtensions.ModifyFunctionOptions(this HotChocolate.Execution.Configuration.IRequestExecutorBuilder! builder, System.Action<HotChocolate.AspNetCore.GraphQLServerOptions!>! configure) -> HotChocolate.Execution.Configuration.IRequestExecutorBuilder!
1 change: 1 addition & 0 deletions src/HotChocolate/Core/src/Abstractions/PublicAPI.Shipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ const HotChocolate.ErrorCodes.Data.NoPagingationProviderFound = "HC0025" -> stri
const HotChocolate.ErrorCodes.Data.SortingProjectionFailed = "HC0024" -> string!
const HotChocolate.ErrorCodes.Execution.AutoMapVarError = "EXEC_BATCH_AUTO_MAP_VAR_TYPE" -> string!
const HotChocolate.ErrorCodes.Execution.Canceled = "HC0049" -> string!
const HotChocolate.ErrorCodes.Execution.CannotCastParent = "HC0053" -> string!
const HotChocolate.ErrorCodes.Execution.CannotCreateRootValue = "HC0019" -> string!
const HotChocolate.ErrorCodes.Execution.CannotResolveAbstractType = "EXEC_UNABLE_TO_RESOLVE_ABSTRACT_TYPE" -> string!
const HotChocolate.ErrorCodes.Execution.CannotSerialize = "EXEC_BATCH_VAR_SERIALIZE" -> string!
Expand Down
1 change: 0 additions & 1 deletion src/HotChocolate/Core/src/Abstractions/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
const HotChocolate.ErrorCodes.Execution.CannotCastParent = "HC0053" -> string!
1 change: 1 addition & 0 deletions src/HotChocolate/Core/src/Types.OffsetPagination/PublicAPI.Shipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ static HotChocolate.Types.OffsetPagingObjectFieldDescriptorExtensions.UseOffsetP
static HotChocolate.Types.OffsetPagingObjectFieldDescriptorExtensions.UseOffsetPaging<TSchemaType>(this HotChocolate.Types.IObjectFieldDescriptor! descriptor, System.Type? itemType = null, HotChocolate.Types.GetOffsetPagingProvider? resolvePagingProvider = null, HotChocolate.Types.Pagination.PagingOptions options = default(HotChocolate.Types.Pagination.PagingOptions)) -> HotChocolate.Types.IObjectFieldDescriptor!
static HotChocolate.Types.Pagination.CollectionSegmentCountType<T>.ApplyConfig(HotChocolate.Types.IObjectTypeDescriptor<HotChocolate.Types.Pagination.CollectionSegment!>! descriptor) -> void
static HotChocolate.Types.Pagination.CollectionSegmentType<T>.ApplyConfig(HotChocolate.Types.IObjectTypeDescriptor<HotChocolate.Types.Pagination.CollectionSegment!>! descriptor) -> void
static HotChocolate.Types.Pagination.Extensions.OffsetPagingQueryableExtensions.ApplyOffsetPaginationAsync<TEntity>(this System.Linq.IQueryable<TEntity>! query, HotChocolate.Resolvers.IResolverContext! context, int? defaultPageSize = null, int? totalCount = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.ValueTask<HotChocolate.Types.Pagination.CollectionSegment<TEntity>!>
static HotChocolate.Types.Pagination.Extensions.OffsetPagingQueryableExtensions.ApplyOffsetPaginationAsync<TEntity>(this System.Linq.IQueryable<TEntity>! query, HotChocolate.Types.Pagination.OffsetPagingArguments arguments, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.ValueTask<HotChocolate.Types.Pagination.CollectionSegment<TEntity>!>
static HotChocolate.Types.Pagination.Extensions.OffsetPagingQueryableExtensions.ApplyOffsetPaginationAsync<TEntity>(this System.Linq.IQueryable<TEntity>! query, int? skip = null, int? take = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.ValueTask<HotChocolate.Types.Pagination.CollectionSegment<TEntity>!>
static Microsoft.Extensions.DependencyInjection.OffsetPagingRequestExecutorBuilderExtension.AddOffsetPagingProvider<TProvider>(this HotChocolate.Execution.Configuration.IRequestExecutorBuilder! builder, string? providerName = null, bool defaultProvider = false) -> HotChocolate.Execution.Configuration.IRequestExecutorBuilder!
Expand Down
1 change: 0 additions & 1 deletion src/HotChocolate/Core/src/Types.OffsetPagination/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
static HotChocolate.Types.Pagination.Extensions.OffsetPagingQueryableExtensions.ApplyOffsetPaginationAsync<TEntity>(this System.Linq.IQueryable<TEntity>! query, HotChocolate.Resolvers.IResolverContext! context, int? defaultPageSize = null, int? totalCount = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.ValueTask<HotChocolate.Types.Pagination.CollectionSegment<TEntity>!>