Add test for arg array typing #4352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccallum
commented
Oct 27, 2021
| @@ -81,6 +81,19 @@ public async Task InvokeAsync(IMiddlewareContext context) | |||
| { | |||
| throw new Exception(); | |||
| } | |||
|
|
|||
| if (context.Selection.Field.Name.Value.StartsWith("array")) | |||
There was a problem hiding this comment.
In v11, arrays are treated as lists, but the arg def also says it's a list, so it was passing the check above.
There was a problem hiding this comment.
so the runtime type is an array? Or what is the issue?
benmccallum
commented
Oct 27, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
michaelstaib
approved these changes
Oct 28, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the test around array args in v12.
(I added this piece for v11 and it fails).