-
-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for arg array typing #4352
Conversation
@@ -81,6 +81,19 @@ public async Task InvokeAsync(IMiddlewareContext context) | |||
{ | |||
throw new Exception(); | |||
} | |||
|
|||
if (context.Selection.Field.Name.Value.StartsWith("array")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In v11, arrays are treated as lists, but the arg def also says it's a list, so it was passing the check above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so the runtime type is an array? Or what is the issue?
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Improves the test around array args in v12.
(I added this piece for v11 and it fails).