Correctly ignore fields using ObjectTypeExtension #4034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michaelstaib Do you see a better way to solve the issue at hand? It feels weird that I have to instantiate a |
tobias-tengler
changed the title
github-actions
bot
added
the
📚 documentation
| // if this definition is used for a type extension we need a | ||
| // binding to a field which shall be ignored. In case this is a | ||
| // definition for the type it will be ignored by the type initialization. | ||
| Definition.FieldIgnores.Add(new ObjectFieldBinding( |
There was a problem hiding this comment.
I have added a note why we have this binding here so that in case of a refactoring we know why this is done.
michaelstaib
approved these changes
Aug 10, 2021
michaelstaib
added
🎬 ready
| foreach (ObjectFieldDescriptor field in Fields) | ||
| { | ||
| if (!field.Definition.Ignore) | ||
| { |
There was a problem hiding this comment.
I fixed the code style here, we always write the braces in C# code in order better see that
if(foo is true)
dosomething();
dosomething(); is really
if(foo is true)
{
dosomething();
}
dosomething(); This issue quickly happens on refactorings and we decided to just enforce braces for if clauses.
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3776