Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to ignore enum values #4020

Merged
merged 5 commits into from
Aug 10, 2021
Merged

Allow to ignore enum values #4020

merged 5 commits into from
Aug 10, 2021

Conversation

tobias-tengler
Copy link
Collaborator

Changes

  • Allow to use [GraphQLIgnore] on enum members
  • Add new IEnumValueDescriptor.Ignore() method as well as IEnumTypeDescriptor.Ignore() as a shorthand

Closes #4019

@tobias-tengler tobias-tengler self-assigned this Jul 31, 2021
@tobias-tengler tobias-tengler added the 👓 ready-for-review The PR is ready for review. label Aug 4, 2021
@michaelstaib
Copy link
Member

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@michaelstaib michaelstaib added 🎬 ready Ready to merge and removed 👓 ready-for-review The PR is ready for review. labels Aug 10, 2021
@michaelstaib michaelstaib merged commit 4e91052 into develop Aug 10, 2021
@michaelstaib michaelstaib deleted the tte/ignore-enum-values branch August 10, 2021 21:23
@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

54.5% 54.5% Coverage
0.0% 0.0% Duplication

@larrifax
Copy link

@michaelstaib is it possible to backport this to 11.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib michaelstaib approved these changes

Assignees

@tobias-tengler tobias-tengler

Labels
🌶️ hot chocolate 🎬 ready Ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to ignore values of an enum
3 participants
@tobias-tengler @michaelstaib @larrifax