Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strawberry guid robustness #3843

Merged

Conversation

dmg-hamann
Copy link
Contributor

set guid to string serialization

  • enhanced UuidSerializer to use Guid.Parse

Closes #3562

@michaelstaib
Copy link
Member

Already skimmed through it .... look really good. Thanks for putting the extra effort into this.... will do a more thorough review tomorrow.

Copy link
Member

@PascalSenn PascalSenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found this one as i skimmed through. Looks very good 👍

src/StrawberryShake/Client/src/Core/ThrowHelper.cs Outdated Show resolved Hide resolved
Co-authored-by: PascalSenn <senn.pasc@gmail.com>
@michaelstaib
Copy link
Member

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@michaelstaib
Copy link
Member

Looks great

@michaelstaib
Copy link
Member

I think we can merge this one tomorrow.

@michaelstaib
Copy link
Member

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@michaelstaib michaelstaib added this to the HC-2021-06 milestone Jun 23, 2021
@michaelstaib
Copy link
Member

@dmg-hamann great work! Thanks for your help. Once build goes green we will merge.

@dmg-hamann
Copy link
Contributor Author

Awesome. Thanks to you guys for this awesome project :)

@michaelstaib michaelstaib merged commit 2f5e58a into ChilliCream:develop Jun 24, 2021
@michaelstaib
Copy link
Member

If you need the feature in 11.x you can do another pr where you cherrypick this change from develop to main. If not it will be included into the next 12 preview. Thanks again from the help and welcome as a contributor.

@gmiserez
Copy link
Contributor

Hi,
Just wanted to thank @dmg-hamann for the fix, as I am currently experiencing this issue on 11.3.0 after migrating from 11.0.0-preview.137.

@dmg-hamann, would you be willing to merge this to the master branch as well? I believe many people who use the release versions of StrawberryShake and HotChocolate (ie 11.X) and use Guids in their Apis might currently be experiencing this issue, so you'll probably make a lot of people happy (definitely me!).

@dmg-hamann
Copy link
Contributor Author

@gmiserez Yeah I will cherry pick the changes and setup a pr

@dmg-hamann dmg-hamann deleted the strawberry-guid-robustness branch June 24, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guid serialization in strawberry shake only accepts one format.
4 participants