-
-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strawberry guid robustness #3843
Strawberry guid robustness #3843
Conversation
Already skimmed through it .... look really good. Thanks for putting the extra effort into this.... will do a more thorough review tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found this one as i skimmed through. Looks very good 👍
Co-authored-by: PascalSenn <senn.pasc@gmail.com>
/AzurePipelines run |
Azure Pipelines successfully started running 2 pipeline(s). |
src/StrawberryShake/Client/src/Core/Serialization/UuidSerializer.cs
Outdated
Show resolved
Hide resolved
Looks great |
I think we can merge this one tomorrow. |
/AzurePipelines run |
Azure Pipelines successfully started running 2 pipeline(s). |
@dmg-hamann great work! Thanks for your help. Once build goes green we will merge. |
Awesome. Thanks to you guys for this awesome project :) |
If you need the feature in 11.x you can do another pr where you cherrypick this change from develop to main. If not it will be included into the next 12 preview. Thanks again from the help and welcome as a contributor. |
Hi, @dmg-hamann, would you be willing to merge this to the master branch as well? I believe many people who use the release versions of StrawberryShake and HotChocolate (ie 11.X) and use Guids in their Apis might currently be experiencing this issue, so you'll probably make a lot of people happy (definitely me!). |
@gmiserez Yeah I will cherry pick the changes and setup a pr |
set guid to string serialization
Closes #3562