-
-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PublicApiAnalyzer refinements #3677
Conversation
This comment has been minimized.
This comment has been minimized.
I will have a look. |
d90fb32
to
5ecdf59
Compare
I will do this tomorrow. :) |
This reverts commit 48fd81e.
This Code Smell should be ignored. It's that the parameter name on the implementation is different from the one on the interface. I removed this Code Smell in another PR, but technically it's a breaking change. Therefor I reverted it and essentially just undid my previous change: |
8590f48
to
53c64fd
Compare
53c64fd
to
c756c42
Compare
AddUnshipped to nuke
@michaelstaib I added the remaining Nuke targets and also tested the GitHub action in my fork of HotChocolate. EDIT: Okay it's not good to go - the Nuke update apparently broke the build ^^ |
@michaelstaib I'm not exactly sure how the changes here have messed with the build/tests, but it seems like we should install all the frameworks we're targeting in the build pipeline, e.g. |
we can ignore this since the API is obsolete and will be removed in future. I will override the validation. |
Build seems to work now again. I updated the devops pipelines to also install the old 3.1 framework. |
Kudos, SonarCloud Quality Gate passed! |
The red tests are flaky ... will deal with them in a separate issue. |
main
branch