Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spatial transformations #2904

Merged
merged 20 commits into from
Feb 19, 2021
Merged

spatial transformations #2904

merged 20 commits into from
Feb 19, 2021

Conversation

PascalSenn
Copy link
Member

Adds reprojection features to spatial types

@steveoh
Copy link
Contributor

steveoh commented Jan 19, 2021

This looks pretty nice.

@PascalSenn PascalSenn changed the title wip: spatial reprojection spatial transformations Jan 20, 2021
@PascalSenn PascalSenn requested a review from steveoh January 20, 2021 02:21
@steveoh
Copy link
Contributor

steveoh commented Jan 20, 2021

It would be nice to add these two defaults from NTS that will be the most popular/common spatial references that folks will be using https://github.com/NetTopologySuite/ProjNet4GeoAPI/blob/6a6ee1c9c1eb27877c43e0a58ae280f7510ef444/src/ProjNet/CoordinateSystemServices.cs#L197-L198.

I would propose to add an extension method to set WGS84 or WebMercator. The WKT string that you have will be great for everything else that NTS can support.

@PascalSenn
Copy link
Member Author

@steveoh added webmercator and WGS84 as extension methods

@steveoh
Copy link
Contributor

steveoh commented Jan 25, 2021

@michaelstaib do you have any comments besides code style?

@michaelstaib
Copy link
Member

Is this done?

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

83.7% 83.7% Coverage
0.0% 0.0% Duplication

@steveoh
Copy link
Contributor

steveoh commented Feb 16, 2021

@michaelstaib do you have any review comments besides code style?

@michaelstaib michaelstaib merged commit aa8d214 into main Feb 19, 2021
@michaelstaib michaelstaib deleted the pse/feat-spatial-reprojection branch February 19, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveoh steveoh steveoh left review comments

@michaelstaib michaelstaib michaelstaib left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PascalSenn @steveoh @michaelstaib