Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #2357

Merged
merged 2 commits into from
Sep 19, 2020
Merged

Update README.md #2357

merged 2 commits into from
Sep 19, 2020

Conversation

damikun
Copy link
Contributor

@damikun damikun commented Sep 19, 2020

Related to have direct link to repos and not to .md files in Project Links..

From Slack...
"Hey @rafael super i think it will be better if product overview will not link to concrete Readme.md but to repo part... It is equal content but with repo you have github src on top... check this to liks as compare: (Without /README.md )

Your current:
https://github.com/ChilliCream/hotchocolate/blob/develop/src/HotChocolate/README.md
What i recomend:
https://github.com/ChilliCream/hotchocolate/tree/develop/src/HotChocolate
This is change:
f2f0f9a (edited)

Update project links
Copy link
Member

@michaelstaib michaelstaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, this seems also better. What do you think @rstaib?

@michaelstaib
Copy link
Member

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@rstaib
Copy link
Member

rstaib commented Sep 19, 2020

@damikun I like it!

@rstaib rstaib merged commit ea2b940 into ChilliCream:develop Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants