Skip to content

[Fusion] Fix subgraph errors being dropped on non-null fields and null list elements - #10464

Merged
michaelstaib merged 3 commits into
mainfrom
mst/fusion-forward-subgraph-errors
Oct 5, 2026
Merged

michaelstaib merged 3 commits into
mainfrom
mst/fusion-forward-subgraph-errors

Conversation

@michaelstaib

Copy link
Copy Markdown
Member

No description provided.

Copilot AI balanced review requested due to automatic review settings October 1, 2026 14:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Descendant error paths are incorrectly truncated to the null list element path.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

Fixes Fusion gateway error forwarding for non-null fields and null list elements.

Changes:

  • Forwards source errors when fields retain values.
  • Preserves descendant errors when list elements become null.
  • Adds integration tests and snapshots for both error modes.
File Description
ValueCompletion.cs Adds source-error forwarding during value completion.
SourceSchemaErrorTests.cs Adds list-element error scenarios.
...Null_Element_OnError_Propagate.yaml Snapshots propagation behavior.
...Null_Element_OnError_Null.yaml Snapshots null-mode behavior.
...Below_Null_List_Element_OnError_Propagate.yaml Snapshots descendant-error propagation.
...Below_Null_List_Element_OnError_Null.yaml Snapshots descendant errors in null mode.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Results/ValueCompletion.cs Outdated
@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Patch coverage

97.4% of changed lines covered (76/78)

File Covered Changed Patch %
…/src/Fusion.Execution/Execution/Results/ValueCompletion.cs 76 78 97.4% 🟡
Uncovered changed lines (JSON)
{
  "sha": "d3fbe00fc8c92e63fb72219972391aa4b4fbda13",
  "files": [
    { "path": "src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Results/ValueCompletion.cs", "ranges": [[1193, 1194]] }
  ]
}

Project coverage: 57.9% (300981/519835 lines)

@michaelstaib
michaelstaib merged commit bb6d834 into main Oct 5, 2026
158 checks passed
@michaelstaib
michaelstaib deleted the mst/fusion-forward-subgraph-errors branch October 5, 2026 01:43
glen-84 pushed a commit that referenced this pull request Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants