Skip to content

Fixed failing tests in the CLI - #10304

Merged
PascalSenn merged 1 commit into
mainfrom
fix/nitro-cli-e2e-goldens
Aug 27, 2026
Merged

PascalSenn merged 1 commit into
mainfrom
fix/nitro-cli-e2e-goldens

Conversation

@PascalSenn

Copy link
Copy Markdown
Member

No description provided.

Copilot AI lite review requested due to automatic review settings August 27, 2026 12:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Nitro CLI E2E (VHS) recordings and goldens to match recent CLI/TUI behavior changes, with an emphasis on making the fixture-backed flows deterministic again so CI stops failing.

Changes:

  • Refreshes multiple .golden.txt snapshots to reflect updated tab headers/footers and revised mail/agent board behavior.
  • Adjusts the E2E harness (run.sh) and documentation to align with fixture-based execution (including sqlite3-prepared fixture DB).
  • Updates tape narratives to reflect actor-less Workspace mail board behavior and the reduced/changed Agents tab scenario.

Reviewed changes

Copilot reviewed 17 out of 27 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/Nitro/CommandLine/test/e2e/search-flow.golden.txt Updates search flow golden to match new header/footer rendering.
src/Nitro/CommandLine/test/e2e/run.sh Updates marker expectations and scrub configuration for current flows.
src/Nitro/CommandLine/test/e2e/README.md Updates flow descriptions and requirements for the revised fixture-based approach.
src/Nitro/CommandLine/test/e2e/mail-send-flow.tape Updates mail-send tape header to describe fixture-copy execution.
src/Nitro/CommandLine/test/e2e/mail-send-flow.golden.txt Updates mail-send transcript (commands/output) to current CLI semantics.
src/Nitro/CommandLine/test/e2e/mail-error-flow.golden.txt Updates mail-error transcript for current CLI arguments/output wrapping.
src/Nitro/CommandLine/test/e2e/mail-board-flow.tape Reworks mail-board tape narrative to the actor-less Workspace mailbox behavior and filtering.
src/Nitro/CommandLine/test/e2e/mail-board-flow.golden.txt Updates mail-board golden to the Workspace-filtered layout and footer hints.
src/Nitro/CommandLine/test/e2e/fixtures/README.md Updates fixture preparation docs to match how run.sh initializes the workspace.
src/Nitro/CommandLine/test/e2e/fixtures/mail-seed.sql Updates comments describing fixture agent usage for mail scenarios.
src/Nitro/CommandLine/test/e2e/detail-flow.golden.txt Updates detail flow golden to match new header/footer rendering.
src/Nitro/CommandLine/test/e2e/create-flow.golden.txt Updates create flow transcript to include explicit actor usage.
src/Nitro/CommandLine/test/e2e/close-reopen-flow.golden.txt Updates close/reopen transcript to include explicit actor usage.
src/Nitro/CommandLine/test/e2e/board-maximize-flow.golden.txt Updates board maximize golden to match new header/footer rendering.
src/Nitro/CommandLine/test/e2e/board-flow.golden.txt Updates board golden to match new header/footer rendering.
src/Nitro/CommandLine/test/e2e/agents-flow.tape Updates Agents tape narrative to reflect a single fixture-seeded session (no live board session row).
src/Nitro/CommandLine/test/e2e/agents-flow.golden.txt Updates Agents golden to match the single-row list and updated footer rendering.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/Nitro/CommandLine/test/e2e/run.sh
@github-actions

Copy link
Copy Markdown
Contributor

🎬 Nitro CLI E2E snapshots changed

These flow recordings differ from main (added, removed, or modified). Expand each for the before/after.

🔁 agents: modified
Before: mainAfter: this PR
recordingrecording
🔁 board: modified
Before: mainAfter: this PR
recordingrecording
🔁 board-maximize: modified
Before: mainAfter: this PR
recordingrecording
🔁 close-reopen: modified
Before: mainAfter: this PR
recordingrecording
🔁 create: modified
Before: mainAfter: this PR
recordingrecording
🔁 detail: modified
Before: mainAfter: this PR
recordingrecording
🔁 mail-board: modified
Before: mainAfter: this PR
recordingrecording
🔁 mail-error: modified
Before: mainAfter: this PR
recordingrecording
🔁 mail-send: modified
Before: mainAfter: this PR
recordingrecording
🔁 search: modified
Before: mainAfter: this PR
recordingrecording

Run 33073585630 · full set in the nitro-e2e-snapshots artifact.

@PascalSenn
PascalSenn merged commit 8d33a76 into main Aug 27, 2026
156 checks passed
@PascalSenn
PascalSenn deleted the fix/nitro-cli-e2e-goldens branch August 27, 2026 13:54
This was referenced Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants