Repository navigation
Fixed failing tests in the CLI - #10304
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Nitro CLI E2E (VHS) recordings and goldens to match recent CLI/TUI behavior changes, with an emphasis on making the fixture-backed flows deterministic again so CI stops failing.
Changes:
- Refreshes multiple
.golden.txtsnapshots to reflect updated tab headers/footers and revised mail/agent board behavior. - Adjusts the E2E harness (
run.sh) and documentation to align with fixture-based execution (includingsqlite3-prepared fixture DB). - Updates tape narratives to reflect actor-less Workspace mail board behavior and the reduced/changed Agents tab scenario.
Reviewed changes
Copilot reviewed 17 out of 27 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Nitro/CommandLine/test/e2e/search-flow.golden.txt | Updates search flow golden to match new header/footer rendering. |
| src/Nitro/CommandLine/test/e2e/run.sh | Updates marker expectations and scrub configuration for current flows. |
| src/Nitro/CommandLine/test/e2e/README.md | Updates flow descriptions and requirements for the revised fixture-based approach. |
| src/Nitro/CommandLine/test/e2e/mail-send-flow.tape | Updates mail-send tape header to describe fixture-copy execution. |
| src/Nitro/CommandLine/test/e2e/mail-send-flow.golden.txt | Updates mail-send transcript (commands/output) to current CLI semantics. |
| src/Nitro/CommandLine/test/e2e/mail-error-flow.golden.txt | Updates mail-error transcript for current CLI arguments/output wrapping. |
| src/Nitro/CommandLine/test/e2e/mail-board-flow.tape | Reworks mail-board tape narrative to the actor-less Workspace mailbox behavior and filtering. |
| src/Nitro/CommandLine/test/e2e/mail-board-flow.golden.txt | Updates mail-board golden to the Workspace-filtered layout and footer hints. |
| src/Nitro/CommandLine/test/e2e/fixtures/README.md | Updates fixture preparation docs to match how run.sh initializes the workspace. |
| src/Nitro/CommandLine/test/e2e/fixtures/mail-seed.sql | Updates comments describing fixture agent usage for mail scenarios. |
| src/Nitro/CommandLine/test/e2e/detail-flow.golden.txt | Updates detail flow golden to match new header/footer rendering. |
| src/Nitro/CommandLine/test/e2e/create-flow.golden.txt | Updates create flow transcript to include explicit actor usage. |
| src/Nitro/CommandLine/test/e2e/close-reopen-flow.golden.txt | Updates close/reopen transcript to include explicit actor usage. |
| src/Nitro/CommandLine/test/e2e/board-maximize-flow.golden.txt | Updates board maximize golden to match new header/footer rendering. |
| src/Nitro/CommandLine/test/e2e/board-flow.golden.txt | Updates board golden to match new header/footer rendering. |
| src/Nitro/CommandLine/test/e2e/agents-flow.tape | Updates Agents tape narrative to reflect a single fixture-seeded session (no live board session row). |
| src/Nitro/CommandLine/test/e2e/agents-flow.golden.txt | Updates Agents golden to match the single-row list and updated footer rendering. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
🎬 Nitro CLI E2E snapshots changedThese flow recordings differ from Run 33073585630 · full set in the nitro-e2e-snapshots artifact. |
This was referenced Aug 29, 2026
Merged
This was referenced Sep 7, 2026
Closed
Closed
Closed
This was referenced Sep 14, 2026
Closed
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 20 updates
DFE-Digital/SUI_Matcher#405
Closed
This was referenced Sep 21, 2026
Closed
Closed
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 20 updates
DFE-Digital/SUI_Matcher#410
Merged
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




















No description provided.