Repository navigation
Improve Nitro schema composition and validation in Aspire - #10179
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the Nitro integration in Fusion Aspire by (1) fetching and applying Nitro stage composition settings during seed acquisition/composition, (2) improving schema validation change parsing/formatting, and (3) providing clearer, actionable dashboard notifications (including deep links to resource logs).
Changes:
- Add a Nitro composition-settings GraphQL operation + client, and merge stage settings into archives (including an initial “no archive yet” seed path).
- Improve schema validation change parsing (support nested change structures) and update formatting/fingerprints accordingly.
- Add/adjust notifications for schema validation and schema composition failures, and update/expand tests + persisted operation IDs.
Reviewed changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/HotChocolate/Fusion/test/Fusion.Aspire.Tests/SchemaCompositionTests.cs | Adds tests for the updated WithGraphQLSchemaComposition overloads/defaults. |
| src/HotChocolate/Fusion/test/Fusion.Aspire.Tests/NitroExtensionsTests.cs | Removes local pragmas now covered by project-level NoWarn. |
| src/HotChocolate/Fusion/test/Fusion.Aspire.Tests/Nitro/NitroSeedUpdateMonitorTests.cs | Updates coordinator construction to include composition-settings client. |
| src/HotChocolate/Fusion/test/Fusion.Aspire.Tests/Nitro/NitroSeedProviderTests.cs | Asserts new NotFound outcome behavior. |
| src/HotChocolate/Fusion/test/Fusion.Aspire.Tests/Nitro/NitroSchemaValidatorTests.cs | Updates expectations for nested schema-change parsing output. |
| src/HotChocolate/Fusion/test/Fusion.Aspire.Tests/Nitro/NitroSchemaValidationNotifierTests.cs | Updates notifier contract and verifies new link/title/message shapes. |
| src/HotChocolate/Fusion/test/Fusion.Aspire.Tests/Nitro/NitroSchemaValidationFormatterTests.cs | Updates formatter snapshots for new wording + severity output. |
| src/HotChocolate/Fusion/test/Fusion.Aspire.Tests/Nitro/NitroSchemaCompositionTests.cs | Adds tests for applying/merging Nitro stage composition settings and composition failure notifications. |
| src/HotChocolate/Fusion/test/Fusion.Aspire.Tests/Nitro/NitroOperationDocumentsTests.cs | Adds tests for new composition-settings operation doc/id and updates validation operation id expectations. |
| src/HotChocolate/Fusion/test/Fusion.Aspire.Tests/Nitro/GatewaySchemaValidationWorkerTests.cs | Updates notifier signature usage in worker tests. |
| src/HotChocolate/Fusion/test/Fusion.Aspire.Tests/HotChocolate.Fusion.Aspire.Tests.csproj | Adds ASPIREINTERACTION001 to NoWarn for tests. |
| src/HotChocolate/Fusion/test/Fusion.Aspire.Tests/CompositionHarness.cs | Wires INitroCompositionNotifier into the harness + provides noop implementation. |
| src/HotChocolate/Fusion/src/Fusion.Aspire/SchemaCompositionRegistration.cs | Registers INitroCompositionNotifier to reuse the existing notifier implementation. |
| src/HotChocolate/Fusion/src/Fusion.Aspire/SchemaComposition.cs | Emits composition-failure notifications (including guarded recomposition paths). |
| src/HotChocolate/Fusion/src/Fusion.Aspire/Nitro/Operations/PollNitroSchemaValidation.graphql.sha256 | Updates persisted operation hash for the validation polling document. |
| src/HotChocolate/Fusion/src/Fusion.Aspire/Nitro/Operations/PollNitroSchemaValidation.graphql | Expands validation polling document to include nested change details via fragments. |
| src/HotChocolate/Fusion/src/Fusion.Aspire/Nitro/Operations/GetNitroCompositionSettings.graphql.sha256 | Adds persisted operation hash for composition settings query. |
| src/HotChocolate/Fusion/src/Fusion.Aspire/Nitro/Operations/GetNitroCompositionSettings.graphql | Adds query to fetch stage composition settings from Nitro. |
| src/HotChocolate/Fusion/src/Fusion.Aspire/Nitro/NitroSeedUpdateNotifier.cs | Aligns notification title/log text with the new Nitro notification naming. |
| src/HotChocolate/Fusion/src/Fusion.Aspire/Nitro/NitroSeedResult.cs | Adds NotFound outcome and updates doc comments. |
| src/HotChocolate/Fusion/src/Fusion.Aspire/Nitro/NitroSeedProvider.cs | Produces NotFound outcome when Nitro has no config and no cache exists. |
| src/HotChocolate/Fusion/src/Fusion.Aspire/Nitro/NitroSeedCoordinator.cs | Fetches stage composition settings, supports “initial seed” creation, and merges settings into archives. |
| src/HotChocolate/Fusion/src/Fusion.Aspire/Nitro/NitroSchemaValidator.cs | Parses nested schema change logs and generates more specific finding messages. |
| src/HotChocolate/Fusion/src/Fusion.Aspire/Nitro/NitroSchemaValidationReport.cs | Extends fingerprinting and finding model to include severity. |
| src/HotChocolate/Fusion/src/Fusion.Aspire/Nitro/NitroSchemaValidationNotifier.cs | Adds composition notifier interface, deep links to logs, and updated notification title/log message. |
| src/HotChocolate/Fusion/src/Fusion.Aspire/Nitro/NitroSchemaValidationFormatter.cs | Updates header wording and includes severity in formatted findings. |
| src/HotChocolate/Fusion/src/Fusion.Aspire/Nitro/NitroSchemaValidationCoordinator.cs | Uses the new notifier signature and updates user-facing messages. |
| src/HotChocolate/Fusion/src/Fusion.Aspire/Nitro/NitroOperationDocuments.cs | Adds composition-settings operation name/document/id accessors. |
| src/HotChocolate/Fusion/src/Fusion.Aspire/Nitro/NitroCompositionSettingsClient.cs | New client to fetch and map Nitro stage composition settings. |
| src/HotChocolate/Fusion/src/Fusion.Aspire/Nitro/INitroCompositionSettingsClient.cs | New abstraction for composition-settings retrieval. |
| src/HotChocolate/Fusion/src/Fusion.Aspire/HotChocolate.Fusion.Aspire.csproj | Adds ASPIREINTERACTION001 to NoWarn and embeds the new operation resources. |
| src/HotChocolate/Fusion/src/Fusion.Aspire/GraphQLResourceBuilderExtensions.cs | Adds a simpler composition configuration overload and adjusts the composition overload surface. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .Append(" operations, ") | ||
| .Append(report.FindingCount) | ||
| .AppendLine(" findings."); | ||
| .Append(report.OperationCount == 1 ? " operation are affected." : " operations are affected.") |
Comment on lines
+232
to
+249
| CompositionSettings? stageSettings; | ||
| try | ||
| { | ||
| stageSettings = await settingsTask; | ||
| } | ||
| catch (Exception exception) when ( | ||
| exception is not OperationCanceledException | ||
| && result.Outcome is NitroSeedOutcome.ServedFromCache) | ||
| { | ||
| stageSettings = null; | ||
| logger.LogWarning( | ||
| exception, | ||
| "The composition settings for the api {ApiId} and the stage {Stage} could not " | ||
| + "be fetched from Nitro. The settings in the cached fusion configuration will " | ||
| + "be used.", | ||
| apiId, | ||
| Stage); | ||
| } |
| public sealed class SchemaCompositionTests | ||
| { | ||
| [Fact] | ||
| public void WithGraphQLSchemaComposition_Should_UseValidationAndOutput_WhenArgumentsAreProvided() |
Comment on lines
86
to
+90
| public static IResourceBuilder<T> WithGraphQLSchemaComposition<T>( | ||
| this IResourceBuilder<T> builder, | ||
| string outputFileName = "gateway.far", | ||
| GraphQLCompositionSettings settings = default) | ||
| bool disableValidation = false, | ||
| string outputFileName = "gateway.far") | ||
| where T : IResourceWithEndpoints |
| @@ -1 +1 @@ | |||
| 6ebe506f2dda96523ef2a0302b7b4aa0f748c2ace6dd5b89449c081c7dbb135e | |||
| 0fcb0a11b85be6ede7bb6141f0cdcc34a3fc7eaa611747d013d02b9374e48e22 | |||
Contributor
Patch coverage72.9% of changed lines covered (320/439)
Uncovered changed lines (JSON){
"sha": "4bb854b923ea26dcd619a4e2b510f0b740947700",
"files": [
{ "path": "src/HotChocolate/Fusion/src/Fusion.Aspire/Nitro/NitroSeedUpdateNotifier.cs", "ranges": [[39, 39], [49, 49]] },
{ "path": "src/HotChocolate/Fusion/src/Fusion.Aspire/SchemaComposition.cs", "ranges": [[524, 526], [528, 531], [584, 584], [845, 854], [856, 859], [868, 868]] },
{ "path": "src/HotChocolate/Fusion/src/Fusion.Aspire/Nitro/NitroSchemaValidationReport.cs", "ranges": [[80, 81]] },
{ "path": "src/HotChocolate/Fusion/src/Fusion.Aspire/Nitro/NitroSchemaValidator.cs", "ranges": [[610, 612], [648, 650], [652, 653], [655, 655], [657, 657], [659, 659], [661, 661], [663, 663], [665, 668], [670, 670], [672, 679], [681, 681], [685, 687], [689, 692]] },
{ "path": "src/HotChocolate/Fusion/src/Fusion.Aspire/Nitro/NitroCompositionSettingsClient.cs", "ranges": [[49, 51], [56, 58], [62, 65], [71, 73], [84, 86], [116, 117], [122, 122], [124, 125], [133, 134], [138, 140], [147, 149], [165, 166], [169, 170], [179, 179], [181, 183], [191, 192]] },
{ "path": "src/HotChocolate/Fusion/src/Fusion.Aspire/Nitro/NitroSeedCoordinator.cs", "ranges": [[237, 249], [382, 385], [387, 387]] },
{ "path": "src/HotChocolate/Fusion/src/Fusion.Aspire/Nitro/NitroSchemaValidationNotifier.cs", "ranges": [[33, 33]] }
]
}Project coverage: 54.0% (237585/439932 lines) |
This was referenced Aug 6, 2026
Merged
This was referenced Aug 13, 2026
Closed
Closed
This was referenced Aug 25, 2026
Closed
This was referenced Sep 1, 2026
Closed
This was referenced Sep 15, 2026
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 20 updates
DFE-Digital/SUI_Matcher#405
Closed
This was referenced Sep 22, 2026
Closed
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 20 updates
DFE-Digital/SUI_Matcher#410
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.