Skip to content

[Fusion] Eliminate redundant parse-flag rescans in SourceResultDocument #10082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelstaib merged 2 commits into from
Jul 10, 2026
Merged

[Fusion] Eliminate redundant parse-flag rescans in SourceResultDocument #10082

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6040ceb
[Fusion] Eliminate redundant parse-flag rescans in SourceResultDocument
michaelstaib Jul 10, 2026
cce60b0
Merge branch 'main' into mst/remove-rescan
michaelstaib Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 4 additions & 29 deletions src/HotChocolate/Fusion/src/Fusion.Execution/Text/Json/SourceResultDocument.Parse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,8 +459,7 @@ private static void ParseJson(
AppendNumberToken(
ref metaDb,
location,
tokenLength,
reader);
tokenLength);
break;

case JsonTokenType.True:
Expand Down Expand Up @@ -531,41 +530,17 @@ private static void AppendStringToken(
tokenType,
startLocation,
tokenLength,
hasComplexChildren: ContainsEscapeSequences(reader));
hasComplexChildren: reader.ValueIsEscaped);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
private static void AppendNumberToken(
ref MetaDb metaDb,
int startLocation,
int tokenLength,
Utf8JsonReader reader)
int tokenLength)
=> metaDb.Append(
JsonTokenType.Number,
startLocation,
tokenLength,
hasComplexChildren: ContainsScientificNotation(reader.ValueSpan));

[MethodImpl(MethodImplOptions.AggressiveInlining)]
private static bool ContainsEscapeSequences(Utf8JsonReader reader)
{
if (reader.HasValueSequence)
{
foreach (var segment in reader.ValueSequence)
{
if (segment.Span.IndexOf(JsonConstants.BackSlash) >= 0)
{
return true;
}
}

return false;
}

return reader.ValueSpan.IndexOf(JsonConstants.BackSlash) is not -1;
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
private static bool ContainsScientificNotation(ReadOnlySpan<byte> value)
=> value.IndexOfAny((byte)'e', (byte)'E') >= 0;
hasComplexChildren: false);
}
Loading