Repository navigation
Fix projection crash on empty nested list sub-projection - #10066
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a crash in queryable projections when a nested list’s sub-projection is empty by ensuring the list handler pops the instance it pushed on enter, keeping the projection context’s instance stack aligned for subsequent sibling selections.
Changes:
- Pop the list instance in
QueryableProjectionListHandler.TryHandleLeavewhen the list sub-projection is empty (prevents sibling scalar binding against the wrong instance). - Add an integration test covering the “empty nested list sub-projection + trailing sibling scalar” scenario reported in #10034.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/HotChocolate/Data/src/Data/Projections/Expressions/Handlers/QueryableProjectionListHandler.cs | Pops the pushed instance on the empty-projection early-return path to prevent instance-stack leakage and downstream binding crashes. |
| src/HotChocolate/Data/test/Data.Projections.Tests/IntegrationTests.cs | Adds an integration test exercising the empty nested list sub-projection scenario with a trailing sibling scalar field. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jul 13, 2026
This was referenced Jul 20, 2026
chore(deps): Bump HotChocolate.Subscriptions.InMemory from 15.1.14 to 16.5.1
Kuestenlogik/Bowire#506
Merged
This was referenced Aug 1, 2026
This was referenced Sep 1, 2026
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 18 updates
DFE-Digital/SUI_Matcher#397
Closed
Closed
This was referenced Sep 15, 2026
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 20 updates
DFE-Digital/SUI_Matcher#405
Closed
This was referenced Sep 22, 2026
Closed
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 20 updates
DFE-Digital/SUI_Matcher#410
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArgumentException: Property '...' is not defined for type 'List<T>'when a nested list's sub-projection was empty and a scalar sibling followed it.QueryableProjectionListHandler.OnBeforeEnterpushes an instance, but the empty-projection early-return inTryHandleLeavenever popped it, so the trailing sibling bound against the leaked list instance.Test plan
Data.Projections.Testspasses (156 tests).