Skip to content

Stabilize flaky NestedDataLoader test #10003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glen-84 merged 2 commits into from
Jun 29, 2026
Merged

Stabilize flaky NestedDataLoader test #10003

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21f5178
Stabilize flaky NestedDataLoader test
glen-84 Jun 29, 2026
8a871ef
Merge branch 'main' into gai/stabilize-nested-dataloader-test
glen-84 Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/HotChocolate/Core/test/Execution.Tests/Integration/DataLoader/DataLoaderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,6 @@ await executor.ExecuteAsync(
public async Task NestedDataLoader()
{
var snapshot = new Snapshot();
using var cts = new CancellationTokenSource(2000);

snapshot.Add(
await new ServiceCollection()
Expand All @@ -385,9 +384,11 @@ public async Task NestedDataLoader()
.AddType<FooQueries>()
.AddDataLoader<FooDataLoader>()
.AddDataLoader<FooNestedDataLoader>()
.ExecuteRequestAsync("query Foo { foo { id field } }", cancellationToken: cts.Token));
.ExecuteRequestAsync(
"query Foo { foo { id field } }",
cancellationToken: TestContext.Current.CancellationToken));

await snapshot.MatchMarkdownAsync(cts.Token);
await snapshot.MatchMarkdownAsync(TestContext.Current.CancellationToken);
}

[Fact]
Expand Down
Loading