Fixed generator issue that affected group and cache DataLoader (#7384)

ChilliCream · Aug 20, 2024 · 9ff9a52 · 9ff9a52
1 parent eb153c2
commit 9ff9a52
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/DataLoaderFileBuilder.cs b/src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/DataLoaderFileBuilder.cs
@@ -92,7 +92,9 @@ public void WriteBeginDataLoaderClass(
             name);
         _writer.IncreaseIndent();
         _writer.WriteIndentedLine(
-            ": global::GreenDonut.DataLoaderBase<{0}, {1}>",
+            kind is DataLoaderKind.Group
+                ? ": global::GreenDonut.DataLoaderBase<{0}, {1}[]>"
+                : ": global::GreenDonut.DataLoaderBase<{0}, {1}>",
             key.ToFullyQualified(),
             value.ToFullyQualified());
         _writer.WriteIndentedLine(", {0}", interfaceName);
@@ -137,7 +139,7 @@ public void WriteDataLoaderConstructor(
             {
                 _writer.WriteIndentedLine("global::System.IServiceProvider services,");
                 _writer.WriteIndentedLine("global::GreenDonut.DataLoaderOptions options)");
-                _writer.WriteIndentedLine(": base(options)");
+                _writer.WriteIndentedLine(": base(AutoBatchScheduler.Default, options)");
             }
         }
 

diff --git a/...__snapshots__/DataLoaderTests.GenerateSource_CacheDataLoader_MatchesSnapshot.md b/...__snapshots__/DataLoaderTests.GenerateSource_CacheDataLoader_MatchesSnapshot.md
@@ -29,7 +29,7 @@ namespace TestNamespace
         public EntityByIdDataLoader(
             global::System.IServiceProvider services,
             global::GreenDonut.DataLoaderOptions options)
-            : base(options)
+            : base(AutoBatchScheduler.Default, options)
         {
             _services = services ??
                 throw new global::System.ArgumentNullException(nameof(services));

diff --git a/...snapshots__/DataLoaderTests.GenerateSource_GroupedDataLoader_MatchesSnapshot.md b/...snapshots__/DataLoaderTests.GenerateSource_GroupedDataLoader_MatchesSnapshot.md
@@ -21,7 +21,7 @@ namespace TestNamespace
     }
 
     public sealed class EntitiesByIdDataLoader
-        : global::GreenDonut.DataLoaderBase<int, Entity>
+        : global::GreenDonut.DataLoaderBase<int, Entity[]>
         , IEntitiesByIdDataLoader
     {
         private readonly global::System.IServiceProvider _services;