TinyIoC NuGet package updated to version 1.3 and TinyIoC made internal #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Erwinvandervalk, @dennisdoomen, we need this change to be able to use Chill in GisVision.Middleware. Can you review/merge/release it, please? |
Contributor
Author
|
@dennisdoomen Can you also tag the release, please? |
IharBury
added a commit
to IharBury/Chill
that referenced
this pull request
May 15, 2017
…TinyIocChillContainer . The build was broken after the pull request ChillBDD#61.
IharBury
added a commit
to IharBury/Chill
that referenced
this pull request
May 15, 2017
…TinyIocChillContainer . The build was broken after the pull request ChillBDD#61.
Collaborator
|
Do you see this as a breaking change? |
Contributor
Author
|
I see it as a breaking change for those who used TinyIoC container from Chill in their specs. |
Collaborator
|
@Erwinvandervalk what about you? |
Collaborator
|
Yeah.. it's breaking because people might not expect this behavior.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #60