Declare project and pytest configuration in pyproject.toml #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses PEP 518 and PEP 621. Drops support for running tests via 'python setup.py'
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=======================================
Coverage 84.83% 84.83%
=======================================
Files 1 1
Lines 310 310
=======================================
Hits 263 263
Misses 47 47 Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
@EpicWink I believe it would be possible to do the main part of this provided that you leave a stup setup.py file around https://pip.pypa.io/en/stable/reference/build-system/pyproject-toml/?highlight=660#editable-installation even without setuptools supporting pep660. How do you think about that |
|
I agree to @jenshnielsen, we should still keep a |
|
Sounds good, I'll get to it tomorrow and test |
This reverts commit 7385cec.
Chilipp
approved these changes
Jul 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses PEP 518 and PEP 621. Drops support for Python 3.6 and running tests via
python setup.py.setup.py-less editable installs are blocked by pypa/setuptools#3082 (likely setuptools v64), so a stub setup.py remains.