Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Vitest & related dependencies (M2-8932) #603

Merged
merged 2 commits into from
Mar 25, 2025

Conversation

andrevitalb
Copy link
Member

📝 Description

🔗 Jira Ticket M2-8932

This PR updates vitest & related dependencies to v1.6.1 to address this critical Dependabot alert.

✏️ Notes

This issue imposes a low to medium risk for this project mainly due to the following.

  1. This is a dev dependency - only used during development, not in production
  2. The vulnerability requires:
    • Vitest UI to be running.
    • Developer to visit a malicious website while running tests.
    • The attacker needs to know the exact test file path to exploit.

The issue is solved in v1.6.1, and upgrading to this version only comes with a minor version bump and no additional changes.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-603.d15zn9do8xbzga.amplifyapp.com

Copy link
Contributor

@mbanting mbanting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI tests work as expected

Local tests work as expected

> yarn test
> yarn test:watch
> yarn test:ui 
> yarn coverage

Reminder that for branch naming the format should be something like chore/M2-8932-update-vitest. Thanks!

@andrevitalb andrevitalb merged commit 67a2922 into dev Mar 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants