Skip to content

Conversation

farmerpaul
Copy link
Contributor

📝 Description

This changes allows Amplify preview environments to continue to work, which do not have Datadog environment variables set.

🪤 Peer Testing

  • Open the Amplify environment associated with this PR.
    Expected outcome: Admin App should load normally, without a JS error displayed in DevTools.

@farmerpaul farmerpaul requested a review from andrevitalb March 13, 2025 16:18
@farmerpaul farmerpaul force-pushed the fix/do-not-crash-without-dd-vars branch from 49d5519 to a83fca8 Compare March 13, 2025 16:19
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-596.d15zn9do8xbzga.amplifyapp.com

@farmerpaul farmerpaul requested a review from aweiland March 13, 2025 16:50
Copy link
Member

@andrevitalb andrevitalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough. I still believe it's worth taking the env variable handling discussion a bit further. A proper handler could bring visibility to issues like these.

@farmerpaul farmerpaul merged commit 0881e8a into dev Mar 13, 2025
4 checks passed
@farmerpaul farmerpaul deleted the fix/do-not-crash-without-dd-vars branch March 13, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants