feat: Greek font update (M2-8442) #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
farmerpaul
approved these changes
Feb 11, 2025
ChaconC
approved these changes
Feb 11, 2025
|
Meant to approve this earlier but dev was down at the time and I wanted to do some minimal testing. Nice work @andrevitalb |
mbanting
approved these changes
Feb 12, 2025
mbanting
approved these changes
Feb 19, 2025
farmerpaul
approved these changes
Feb 19, 2025
Phillipe-Bojorquez
changed the title
Phillipe-Bojorquez
changed the title
andrevitalb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Jira Ticket M2-8442
This PR adds Lato as a font for greek characters with the use of CSS's
unicode-rangeproperty. Atkinson remains as the default font for non-greek characters.Some minor cleanup work was done as well for manual overrides along the project by defaulting MUI and the project to the following:
font-family: "Lato", "Atkinson", sans-serif(configuration for the expected behavior added).📸 Screenshots
🪤 Peer Testing
This is only visually testable. Lato should be the default font for greek characters, Atkinson should be present elsewhere.
✏️ Notes
In order to achieve maximum cohesion between the two fonts used, Lato Black was used, instead of the default Lato Bold, since its weight more closely aligns with Atkinson's Bold.