Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use the correct constant for the iOS version number (M2-8843) #955

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

sultanofcardio
Copy link
Contributor

@sultanofcardio sultanofcardio commented Mar 12, 2025

📝 Description

🔗 Jira Ticket M2-8443

This PR fixes the iOS version being sent to the backend from the mobile app in the OS-Version http header.

📸 Screenshots

Pay attention to the os_version column

Before (Optional) After
image image

🪤 Peer Testing

  1. Build and run the mobile app on an iOS device, and log in
  2. Check the user_device_events_history table in the database and look for rows with ios as the os_name
  3. Confirm that the os_version is the correct version of iOS running on the device, and not the string iOS

✏️ Notes

N/A

@sultanofcardio sultanofcardio self-assigned this Mar 12, 2025
Copy link
Contributor

@farmerpaul farmerpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still can't submit answers to my localhost BE (did you ever solve that?), so I just added a console.log to confirm the correct header is being sent.

@sultanofcardio
Copy link
Contributor Author

@farmerpaul you can get around the answer submission issue by commenting out this line on the BE. But you don't need to submit answers to check this ticket, only log in (or swipe refresh), then check the db table for the record

@sultanofcardio sultanofcardio changed the title Use the correct constant for the iOS version number fix: Use the correct constant for the iOS version number (M2-8443) Mar 12, 2025
@sultanofcardio sultanofcardio changed the title fix: Use the correct constant for the iOS version number (M2-8443) fix: Use the correct constant for the iOS version number (M2-8843) Mar 12, 2025
@sultanofcardio sultanofcardio merged commit 201045d into release/2025.03.1 Mar 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants