Skip to content

Conversation

@hardikpatil
Copy link
Contributor

In this PR:

  • Added minor changes in form (As per docs/Foodbank ER Diagram.png schema , in the sign-up View, added fielda First Name, Last Name replacing Name field)
  • Completed form validation on both login, and register views, with reference to issue Form Validation  #89

Copy link
Contributor

@shmansa shmansa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Screenshot (250)
Screenshot (252)
Screenshot (254)
Screenshot (259)
Screenshot (260)
Screenshot (261)
Screenshot (262)

Copy link
Contributor

@prasannarajezzzy prasannarajezzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are working fine

@hardikpatil hardikpatil merged commit f709d0a into frontend Apr 5, 2023
@hardikpatil hardikpatil deleted the feature/form-validation-login-register branch April 5, 2023 00:04
@hardikpatil hardikpatil mentioned this pull request Apr 5, 2023
2 tasks
@AbhinavReddy-Dev
Copy link
Contributor

@hardikpatil @prasannarajezzzy can we please have the updated pages in the Figma for login and signup?

@hardikpatil
Copy link
Contributor Author

@hardikpatil @prasannarajezzzy can we please have the updated pages in the Figma for login and signup?

Oh yes, gotta update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI Concerns UI presentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants