Add Sign Up and Login Pages (#66) #84

prestonmasseyblake · 2023-03-28T03:31:09Z

This pull request adds the sign up and login pages to the project, addressing issue #66. Users can now create new accounts and log in to access the features of the application functionality needs to be implemented by backend team now it just pushes you to homepage. This will enhance the user experience and increase the functionality of the project. The new pages are designed to be user-friendly and intuitive, with clear instructions and error messages to guide users through the process. By adding these essential features, we can improve the overall usability and accessibility of the application.

See FIGMA for what the designs look like

hardikpatil · 2023-03-28T04:05:30Z

Validation? required field validations ain't working on my end.

AbhinavReddy-Dev

Also the validations are not completely working including empty fields and formats.

AbhinavReddy-Dev · 2023-03-28T05:34:46Z

PantryNodeReact/src/pages/login.tsx

+function Copyright(props: any) {
  return (
-    <div>
-      login
-      <Button onClick={() => navigate("/")}> Submit</Button>
-    </div>
+    <Typography variant="body2" color="text.secondary" align="center" {...props}>
+      {'Copyright © '}
+
+        Pantry Node
+      {' '}
+      {new Date().getFullYear()}
+      {'.'}
+    </Typography>
  );
-};
+}


Can we have this component in a separate file under Components folder since we are using it twice again in signup page?

Sure that is something can be done later I wanted to get this merged today so we could talk to the backend team about having them then provide the endpoints for authentication.

I did this one

I did all of these approve this

AbhinavReddy-Dev · 2023-03-28T05:36:39Z

PantryNodeReact/src/pages/register.tsx

+  );
+}
+
+const theme = createTheme();


Please check the src/index.tsx file, we already have a theme provider wrapped around the whole app.

okay I can reference the theme. The home page isn't following correct color codes?

I did all of these approve this

AbhinavReddy-Dev · 2023-03-28T05:38:48Z

PantryNodeReact/src/pages/login.tsx

+                </Link> */}
+              </Grid>
+              <Grid item>
+                <Link href="/signup" variant="body2">


Is it possible to have another link for 'forgot password?'?

its there it is just commented out because I don't want the people to focus on how to have session with Token I want the focus being on getting the Login Workflow Correct and Talking to the backend team.

I did all of these approve this

AbhinavReddy-Dev · 2023-03-28T05:41:29Z

PantryNodeReact/src/pages/register.tsx

+
+const theme = createTheme();
+
+export default function SignUp() {


Have you given a thought about switching between the components of 'Login', 'Signup', and 'ForgotPassowrd'? under a single page based on the user selection?

I did all of these approve this

DevangRaval1 · 2023-03-28T05:43:52Z

The Pages work and navigate to the home page on submit.

AbhinavReddy-Dev · 2023-03-28T05:47:38Z

Yes, the UI navigation works as expected.

hardikpatil · 2023-03-28T05:57:58Z

Also, according to latest model I checked, we would required separate fields for first name and last name @AbhinavReddy-Dev @prestonmasseyblake . Address we can add later Profile update page future issue.

AbhinavReddy-Dev · 2023-03-30T03:18:24Z

@prestonmasseyblake Everything else looks good to me! Just some minor updates before we can merge it tonight.

hardikpatil · 2023-03-30T06:11:08Z

Validations still ain't working on my codespace :/ @AbhinavReddy-Dev

AbhinavReddy-Dev · 2023-03-30T06:50:50Z

Delete the old one and create a new one.

AbhinavReddy-Dev · 2023-03-30T06:55:57Z

I do see that the email format is not working as expected, after review by @DevangRaval1 .

DevangRaval1 · 2023-03-30T06:56:42Z

Email format and password format validations not working

DevangRaval1 · 2023-03-30T06:59:32Z

Also, the phone number validation not working as expected

hardikpatil · 2023-03-30T07:11:24Z

Oh I see yeah, thanks. Validations works now!

hardikpatil · 2023-03-30T07:17:50Z

As per schema is in main docs/[Foodbank ER Diagram.png]

As per docs/Foodbank ER Diagram.png schema, @prestonmasseyblake change the placeholder name to as Username to avoid ambiguity. First Name and Last Name we can later put it in Profile Update View to update additional information, if that remains in scope.

briswells · 2023-03-30T15:48:54Z

Can we place try and avoid doing work in personal forks. This should be done in a feature branch so users don't need to clone a new repo to review, it messing with issues tracking, referencing changes, etc.

prestonmasseyblake · 2023-03-30T16:24:51Z

Why don't we get this merged and open up a new issue for the email, phone and password, validation.

prestonmasseyblake · 2023-03-30T16:27:23Z

I can do that but I would like this to be merged so the other teams can see what the login, signup look like and start working on the authentication part in terms of the backend and thinking about how they are going to implement forgot password. I can write the validation functions later today or tomorrow. Pull requests should not be dozens of commits.

AbhinavReddy-Dev · 2023-03-30T17:36:18Z

We tend to develop on the personal_branch then squash and merge into frontend branch and in the end create a pull request once confirmed by the peers.

briswells · 2023-03-30T17:55:42Z

That sounds great. This PR doesn't seem to be following those practices though.

hardikpatil · 2023-03-30T18:27:33Z

so for the feature branches, should we checkout from frontend or main ?

AbhinavReddy-Dev · 2023-03-30T18:38:54Z

Where ever you checkout from, merge it into 'frontend' initially by creating a pull request to check for any changes necessary and then finally create a pull request to main. We would like to keep the main branch clean from all trivial commits.

hardikpatil · 2023-03-30T18:46:32Z

so basically following steps involved, correct if I miss anything @AbhinavReddy-Dev

pull from main,
checkout from main,
pull from frontend,
merge with feature branch
**** do some work ****
push feature to the main

AbhinavReddy-Dev · 2023-03-30T18:56:23Z

You got it 60-70% correct.

Check if frontend is up to date with main.
Checkout new feature_branch from frontend.
Develop in feature_branch.
Create a pull request from feature_branch to frontend and request for a review before squash and merge.
Create a pull request from frontend to main for rebase and merge.

If anyone has a better approach please let us know here.

hardikpatil · 2023-03-30T19:15:46Z

gotcha! So, what should we do with this PR? I suppose, for now we can make exceptional for this pr, merging with main and then merge. main with the frontend branch.
For future feature_branches we can start implementing the above steps

hardikpatil · 2023-03-30T19:22:37Z

@AbhinavReddy-Dev or we can actually change the base here. Should we do that? from main to frontend .

briswells · 2023-03-30T19:33:24Z

That looks great to me, people just need to remember that if you are using a fork there would be an additional step of pushing local for changes to

I think all PR's to main need to come from repo feature branches not forks, so this PR should be canceled and recreated from a feature branch in our shared repo. We should avoid doing work in forks if at all possible and keep everything as a feature branches so anyone can see what commits are going on without needing to find a different repo.

DevangRaval1 · 2023-03-30T20:10:04Z

ok makes sense

hardikpatil · 2023-03-30T20:10:09Z

And we had discussed this one
#38

Yeah and we did discuss this in #38 that not to use forks.

AbhinavReddy-Dev · 2023-03-30T20:10:41Z

Yeah, we can then merge it into main with a pull request, that should solve the issue of forks. @prestonmasseyblake What do you say? We can then merge it with a proper pull request following the practice for this repo.

Need to make a new pr

parthpandey1

LGTM

prestonmasseyblake added 3 commits March 27, 2023 20:14

added the login and signup pages

844e593

added the sign up and login pages closes ChicoState#66

7335751

Add Sign Up and Login Pages (ChicoState#66) fixed imports

530a069

prestonmasseyblake requested review from AbhinavReddy-Dev, DevangRaval1, hardikpatil and sathyanarayanan-v March 28, 2023 03:32

AbhinavReddy-Dev reviewed Mar 28, 2023

View reviewed changes

prestonmasseyblake added 4 commits March 29, 2023 19:10

refactor copyright component

64d233c

refactored components to use the theme

9f2a4d7

added basic form validation

4dde4d9

added forgot password link

e3a9715

prestonmasseyblake requested review from Anoushka444, Jayesh-sathe, abhilashSreenivasa, abhinaydruva and arshiya19 March 30, 2023 03:03

hardikpatil removed the request for review from Anoushka444 March 30, 2023 07:19

hardikpatil requested review from AbhinavReddy-Dev, briswells and decoles and removed request for arshiya19 March 30, 2023 07:19

DevangRaval1 previously approved these changes Mar 30, 2023

View reviewed changes

DevangRaval1 self-requested a review March 30, 2023 20:06

AbhinavReddy-Dev removed their request for review March 30, 2023 20:11

hardikpatil requested a review from Jooms March 30, 2023 20:46

prestonmasseyblake requested a review from parthpandey1 March 31, 2023 00:19

parthpandey1 approved these changes Mar 31, 2023

View reviewed changes

hardikpatil approved these changes Mar 31, 2023

View reviewed changes

hardikpatil merged commit 3cdee28 into ChicoState:main Mar 31, 2023

hardikpatil added UI Concerns UI presentation feature New feature or request labels Mar 31, 2023


		const theme = createTheme();

		export default function SignUp() {

Add Sign Up and Login Pages (#66) #84

Add Sign Up and Login Pages (#66) #84

Uh oh!

Conversation

prestonmasseyblake commented Mar 28, 2023

Uh oh!

hardikpatil commented Mar 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AbhinavReddy-Dev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DevangRaval1 commented Mar 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AbhinavReddy-Dev commented Mar 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hardikpatil commented Mar 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AbhinavReddy-Dev commented Mar 30, 2023

Uh oh!

hardikpatil commented Mar 30, 2023

Uh oh!

AbhinavReddy-Dev commented Mar 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AbhinavReddy-Dev commented Mar 30, 2023

Uh oh!

DevangRaval1 commented Mar 30, 2023

Uh oh!

DevangRaval1 commented Mar 30, 2023

Uh oh!

hardikpatil commented Mar 30, 2023

Uh oh!

hardikpatil commented Mar 30, 2023

Uh oh!

briswells commented Mar 30, 2023

Uh oh!

prestonmasseyblake commented Mar 30, 2023

Uh oh!

prestonmasseyblake commented Mar 30, 2023

Uh oh!

AbhinavReddy-Dev commented Mar 30, 2023

Uh oh!

briswells commented Mar 30, 2023

Uh oh!

hardikpatil commented Mar 30, 2023

Uh oh!

AbhinavReddy-Dev commented Mar 30, 2023

Uh oh!

hardikpatil commented Mar 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AbhinavReddy-Dev commented Mar 30, 2023

hardikpatil commented Mar 28, 2023 •

edited

Loading

DevangRaval1 commented Mar 28, 2023 •

edited

Loading

AbhinavReddy-Dev commented Mar 28, 2023 •

edited

Loading

hardikpatil commented Mar 28, 2023 •

edited

Loading

AbhinavReddy-Dev commented Mar 30, 2023 •

edited

Loading

hardikpatil commented Mar 30, 2023 •

edited

Loading