-
Notifications
You must be signed in to change notification settings - Fork 35
Donor Page View API + Frontend Add Donor + Donate Functionality #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Created a GET endpoint to fetch all users with at least one donation.
Should return a JSON with person_id, full name and email of all donors. |
|
@parthpandey1 Code look awesome, and works correctly. Could you add authentication to the route. Just passing ensureAuthenticated as a route argument does not cause it to require authentication. You can look at the /feed route for an example. |
…ation in /donors endpoint
|
Did the following as part of 1b38344 and 5181aab :
and hit save. After doing so you can click the 3 dots shown when highlighting your collection on the left, click Add Request and input values required for testing.
This completes the 2nd BE task in #193 Note: The first_name and last_name search parameters do not have to be exact (for example if dummy_data.sql is run, http://localhost:3001/lookupDonor?first_name=John and http://localhost:3001/lookupDonor?first_name=Joh will return the same result). However, person_id should be exact to return results.
|
|
Looks great. Sorry I didn't notice this earlier but I would suggest is changing the names of the query parameters to be fname, and lname, just to keep everything consistent. You could also map the return dict so it returns data using the same dict keys that are being used for the API query parameter. Although this may cause confusion as different user routes might return the same fields named different things. |
) 1. Show donor details 2. Show all the transactions/donations made by them. 3. Make a new donation. These will be the fixes for #193 : Donor Lookup Page Updates: 1. Donate Button routes to the donor view page Donor View Page: 1. Show donations made prior 3. Make a new donation (with the API request created by @parthpandey1 )
|
I've opened this PR for review since it has so much code and checks off 13 out of the 16 original subtasks. The remaining tasks are broken down into #232, #233, #234. Heads-up to any code reviewers, there was a significant amount of UI edits merged to main that generated conflicts, resolving those conflicts generated code bloat in this branch. |
reembot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Live review performed with @ysiddhapura -
Reduced feature targets to mitigate PR bloat. New issues have been created for pending funtionality/features.
jayrevolinskyjr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Runs like a charm on my machine


Donor Feature work in progress
Refer to #193