Skip to content

Link SKU Lookup Feature to Database #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jayrevolinskyjr merged 11 commits into from
Apr 30, 2023
Merged

Link SKU Lookup Feature to Database #176

jayrevolinskyjr merged 11 commits into from
Apr 30, 2023

Conversation

@jayrevolinskyjr
Copy link
Contributor

@jayrevolinskyjr jayrevolinskyjr commented Apr 20, 2023

This is the pull request related to #174

@jayrevolinskyjr jayrevolinskyjr linked an issue Apr 20, 2023 that may be closed by this pull request
Link Database to SKU Feature Lookup #174
Closed
3 tasks
@jayrevolinskyjr
Copy link
Contributor Author

jayrevolinskyjr commented Apr 27, 2023 •
edited
Loading

BarcodeProxy
Update: This is outdated, the .csv functionality was converted into a local implementation of the database on the backend and the OpenFoodFacts get request is so simple that all of this functionality was condensed into a single lookup() function.

@jayrevolinskyjr jayrevolinskyjr marked this pull request as ready for review April 29, 2023 21:32
@jayrevolinskyjr
Copy link
Contributor Author

jayrevolinskyjr commented Apr 29, 2023

The frontend barcode input form is confirmed to talk to the backend, this PR resolves subtask 1, 2, and 4 for #174. Another PR will be open to complete the SKU Lookup Feature Functionality.

@briswells briswells self-requested a review April 29, 2023 21:42
briswells
briswells approved these changes Apr 29, 2023
View reviewed changes
Copy link
Contributor

@briswells briswells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After deleting the DB and recreating it, feature worked as expected. No output was visually show on website, but feature was show to be working via browser and backend console.

ysiddhapura
ysiddhapura approved these changes Apr 29, 2023
View reviewed changes
Copy link
Contributor

@ysiddhapura ysiddhapura left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tried a few barcode entries and the console seems to recognize barcodes from the PLU data and will show as product not found in the console through inspect element.

image

@jayrevolinskyjr jayrevolinskyjr merged commit 7dd88d7 into main Apr 30, 2023
@jayrevolinskyjr jayrevolinskyjr deleted the linkSKU branch April 30, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briswells briswells briswells approved these changes

@ysiddhapura ysiddhapura ysiddhapura approved these changes

@Anoushka444 Anoushka444 Awaiting requested review from Anoushka444

@parthpandey1 parthpandey1 Awaiting requested review from parthpandey1

Assignees

@briswells briswells

@jayrevolinskyjr jayrevolinskyjr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Link Database to SKU Feature Lookup

3 participants

@jayrevolinskyjr @briswells @ysiddhapura